Closed Bug 1050124 Opened 8 years ago Closed 8 years ago

[TSF] Support TSATTRID_Text_VerticalWriting

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(1 file)

We've never handled this. However, some TIPs check this value. And then, we shouldn't return error. We should return "no supported".
Until we support a vertical layout?
(In reply to Masatoshi Kimura [:emk] from comment #1)
> Until we support a vertical layout?

Yes. And I misunderstand. We should return "horizontal layout" always.
This patch makes nsTextStore always returns "horizontal text" for querying TSATTRID_Text_VerticalWriting.

A couple of TIP developers who I know notified me of that only Gecko returns error for this attribute. So, some TIPs might not expect we return "unsupported" for it.
Attachment #8469334 - Flags: review?(jmathies)
Attachment #8469334 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/6a76adda5d24
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment on attachment 8469334 [details] [diff] [review]
Support TSATTRID_Text_VerticalWriting for consistency with other TSF aware applications

Review of attachment 8469334 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsTextStore.cpp
@@ +2406,5 @@
> +  mRequestedAttrValues = false;
> +
> +  if (count) {
> +    *pcFetched = count;
> +    return NS_OK;

This should be return S_OK, I think.
You need to log in before you can comment on or make changes to this bug.