1050124 - [TSF] Support TSATTRID_Text_VerticalWriting

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We've never handled this. However, some TIPs check this value. And then, we shouldn't return error. We should return "no supported".

Comment 1

[Masatoshi Kimura [:emk]]

Until we support a vertical layout?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Masatoshi Kimura [:emk] from comment #1)
> Until we support a vertical layout?

Yes. And I misunderstand. We should return "horizontal layout" always.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Support TSATTRID_Text_VerticalWriting for consistency with other TSF aware applications

This patch makes nsTextStore always returns "horizontal text" for querying TSATTRID_Text_VerticalWriting.

A couple of TIP developers who I know notified me of that only Gecko returns error for this attribute. So, some TIPs might not expect we return "unsupported" for it.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a76adda5d24

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a76adda5d24

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8469334 [details] [diff] [review]
Support TSATTRID_Text_VerticalWriting for consistency with other TSF aware applications

Review of attachment 8469334 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsTextStore.cpp
@@ +2406,5 @@
> +  mRequestedAttrValues = false;
> +
> +  if (count) {
> +    *pcFetched = count;
> +    return NS_OK;

This should be return S_OK, I think.