1050133 - Port TBPL's DOMWINDOW leak analyser to automationutils.py

Status: RESOLVED INCOMPLETE

(Testing :: General, defect, P3)

Description

[Ed Morley [:emorley]]

Treeherder is missing TBPL's leak analyser feature, which is linked from the error summary box on runs that displayed a leak. Instead of adding this functionality to treeherder, IMO we should just improve the output of the existing leakcheck feature in automationutils.py, rather than having to use an external tool to parse the log again.

TBPL's code is at:
https://hg.mozilla.org/webtools/tbpl/file/default/php/inc/LeakAnalyzer.php#l26

Comment 1

[Ed Morley [:emorley]]

http://mxr.mozilla.org/mozilla-central/source/build/automationutils.py#311

Comment 2

[Ed Morley [:emorley]]

Search for recent leak bugs:
https://bugzilla.mozilla.org/buglist.cgi?keywords=intermittent-failure%2C%20&keywords_type=allwords&list_id=10943614&short_desc=leak&resolution=---&chfieldto=Now&query_format=advanced&chfieldfrom=-1m&short_desc_type=allwordssubstr&longdesc=bytes%20leaked&longdesc_type=substring

Comment 3

[Dan Minor [:dminor]]

khuey, is this code still useful? Ed suggested I double check with someone familiar with the in-tree code before proceeding. Thanks!

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I think you should ask some of the front end folks like dao or ttaubert.

Comment 5

[Dan Minor [:dminor]]

Hi, just wanted to check if this functionality is still useful before porting it. Thanks!

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

It sounds like you're talking about a the leak analyzer that was written for leaks in native code? I only know about the ShutdownLeaks code which never had an "analyzer". The log messages there are as good as possible and tell which test leaked.

Comment 7

[Dan Minor [:dminor]]

Ok, sounds like this is no longer useful. Thanks!

Comment 8

[Phil Ringnalda (:philor)]

No, his answer was "I don't know about that thing, I wrote something different to deal with a different sort of leaks."

This is for leaks like bug 1045822, where we have two clues, the list of leaked objects which is rarely useful for anything, and the list of leaked URLs, which may or may not be useful sometimes with some interpretation, and we used to have this third tool which came from bug 538462 comment 16 which looked for instances of ++DOMWINDOW in the log that didn't have a matching --DOMWINDOW, and listed the active test when one was found, which was sometimes useful.

It was always too confusing (sounding like it was saying "nothing really leaked!" when it was really saying "I don't have anything useful to say about that leak" and requiring that you know what things are false positives) for the sort of primary positioning it got in tbpl back when it worked, but if right above the list of leaked URLs that's only looked at by people who know something, we also had the output of this, there would be cases where it would directly blame a leak on the test which was causing the leak. If I were to pick someone to say whether or not they needed that, I'd pick Andrew.

Comment 9

[Andrew McCreight [:mccr8]]

I've never actually looked at the output of this particular leak analyzer, so I don't know how useful it is in practice.  The ++DOMWINDOW and --DOMWINDOW stuff is less flakey than it used to be, I think due to work by ttaubert.  Like philor said it would be nice to have some little output like this near the leaked URLs list of windows that might be leaked, as it would point more directly at problems.

Comment 10

[Ed Morley [:emorley]]

I don't believe this should block TBPL EOL, adjusting accordingly.

Comment 11

[Dan Minor [:dminor]]

Not sure I'll have a chance to look at this one any time soon.

Comment 12

[Ed Morley [:emorley]]

Mass-closing old bugs I filed that have not had recent activity/no longer affect me.