1050163 - bzpost should prompt for password for a few times if user types wrong password

Status: RESOLVED WONTFIX

(Developer Services :: Mercurial: bzpost, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I only store bugzilla username in the config. When I typed a wrong password, bzpost should ask me again. But I got this exception instead :/

Traceback (most recent call last):
  File "/usr/local/bin/hg", line 38, in <module>
    mercurial.dispatch.run()
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 28, in run
    sys.exit((dispatch(request(sys.argv[1:])) or 0) & 255)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 69, in dispatch
    ret = _runcatch(req)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 138, in _runcatch
    return _dispatch(req)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 819, in _dispatch
    cmdpats, cmdoptions)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 599, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/hgext/color.py", line 431, in colorcmd
    return orig(ui_, opts, cmd, cmdfunc)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/hgext/pager.py", line 138, in pagecmd
    return orig(ui, options, cmd, cmdfunc)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 910, in _runcommand
    return checkargs()
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 881, in checkargs
    return cmdfunc()
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/dispatch.py", line 816, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/util.py", line 518, in check
    return func(*args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 151, in wrap
    util.checksignature(origfn), *args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/util.py", line 518, in check
    return func(*args, **kwargs)
  File "/Users/tlin/.mozbuild/version-control-tools/hgext/reviewboard/client.py", line 122, in pushcommand
    return orig(ui, repo, *args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/util.py", line 518, in check
    return func(*args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 151, in wrap
    util.checksignature(origfn), *args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/util.py", line 518, in check
    return func(*args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/hgext/mq.py", line 3387, in mqcommand
    return orig(ui, repo, *args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/util.py", line 518, in check
    return func(*args, **kwargs)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/commands.py", line 4717, in push
    newbranch=opts.get('new_branch'))
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/localrepo.py", line 1725, in push
    return exchange.push(self, remote, force, revs, newbranch)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/Users/tlin/.mozbuild/version-control-tools/hgext/firefoxtree/__init__.py", line 164, in push
    return orig(repo, remote, force=force, revs=revs, newbranch=newbranch)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/Users/tlin/.mozbuild/version-control-tools/hgext/reviewboard/client.py", line 130, in wrappedpush
    return orig(repo, remote, force=force, revs=revs, newbranch=newbranch)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/exchange.py", line 151, in push
    _pushbookmark(pushop)
  File "/usr/local/Cellar/mercurial/3.0.2/lib/python2.7/site-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/Users/tlin/.mozbuild/version-control-tools/hgext/bzpost/__init__.py", line 133, in wrappedpushbookmark
    bugzilla_url=bzurl)
  File "/Users/tlin/.mozbuild/version-control-tools/pylib/Bugsy/bugsy/bugsy.py", line 66, in __init__
    raise LoginException(result['message'])
bugsy.bugsy.LoginException: Message: The username or password you entered is not valid.

Comment 1

[Gregory Szorc [:gps]]

We now have Bugzilla API keys and it is expected that these will be stored in hgrc files. Passwords shouldn't ever come into the picture any more.