[Bluetooth] Port bug 992206 to bluetooth2

RESOLVED FIXED

Status

Firefox OS
Bluetooth
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(12 attachments)

3.63 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
2.98 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
5.95 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
3.61 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
2.35 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
2.35 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
1.81 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
7.39 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
5.44 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
1.96 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
2.31 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
8.14 KB, patch
Ben Tian (inactive)
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
Created attachment 8475758 [details] [diff] [review]
[01] Bug 1050174: Cleanup fields in |DroidSocketImpl| (under bluetooth2/)
Attachment #8475758 - Flags: review?(btian)
Created attachment 8475759 [details] [diff] [review]
[02] Bug 1050174: Use |SocketConsumerBase| for Bluetooth sockets (under bluetooth2/)
Attachment #8475759 - Flags: review?(btian)
Created attachment 8475760 [details] [diff] [review]
[03] Bug 1050174: Use |SocketIORunnable| for Bluetooth sockets (under bluetooth2/)
Attachment #8475760 - Flags: review?(btian)
Created attachment 8475761 [details] [diff] [review]
[04] Bug 1050174: Use |SocketIOEventRunnable| for Bluetooth sockets (under bluetooth2/)
Attachment #8475761 - Flags: review?(btian)
Created attachment 8475763 [details] [diff] [review]
[05] Bug 1050174: Use |SocketIOReceiveRunnable| for Bluetooth sockets (under bluetooth2/)
Attachment #8475763 - Flags: review?(btian)
Created attachment 8475764 [details] [diff] [review]
[06] Bug 1050174: Use |SocketIORequestClosingRunnable| for Bluetooth sockets (under bluetooth2/)
Attachment #8475764 - Flags: review?(btian)
Created attachment 8475767 [details] [diff] [review]
[07] Bug 1050174: Use |SocketIODeleteInstanceRunnable| for Bluetooth sockets (under bluetooth2/)
Attachment #8475767 - Flags: review?(btian)
Created attachment 8475769 [details] [diff] [review]
[08] Bug 1050174: Use |SocketIOBase| for Bluetooth sockets (under bluetooth2/)
Attachment #8475769 - Flags: review?(btian)
Created attachment 8475771 [details] [diff] [review]
[09] Bug 1050174: Use |SocketIOTask| for Bluetooth sockets (under bluetooth2/)
Attachment #8475771 - Flags: review?(btian)
Created attachment 8475773 [details] [diff] [review]
[10] Bug 1050174: Use |SocketIOSendTask| for Bluetooth sockets (under bluetooth2/)
Attachment #8475773 - Flags: review?(btian)
Created attachment 8475775 [details] [diff] [review]
[11] Bug 1050174: Use |SocketIOShutdownTask| for Bluetooth sockets (under bluetooth2/)
Attachment #8475775 - Flags: review?(btian)
Created attachment 8475777 [details] [diff] [review]
[12] Bug 1050174: Cleanup interface of |BluetoothSocket| (under bluetoth2/)
Attachment #8475777 - Flags: review?(btian)
Hi Ben,

This patchset replaces code of BluetoothSocket with a generic implementation. It's a lot of patches, but often only little change per patch.

Comment 14

4 years ago
Comment on attachment 8475760 [details] [diff] [review]
[03] Bug 1050174: Use |SocketIORunnable| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475760 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475760 - Flags: review?(btian) → review+

Comment 15

4 years ago
Comment on attachment 8475761 [details] [diff] [review]
[04] Bug 1050174: Use |SocketIOEventRunnable| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475761 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475761 - Flags: review?(btian) → review+

Comment 16

4 years ago
Comment on attachment 8475763 [details] [diff] [review]
[05] Bug 1050174: Use |SocketIOReceiveRunnable| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475763 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475763 - Flags: review?(btian) → review+

Comment 17

4 years ago
Comment on attachment 8475764 [details] [diff] [review]
[06] Bug 1050174: Use |SocketIORequestClosingRunnable| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475764 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475764 - Flags: review?(btian) → review+

Comment 18

4 years ago
Comment on attachment 8475767 [details] [diff] [review]
[07] Bug 1050174: Use |SocketIODeleteInstanceRunnable| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475767 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475767 - Flags: review?(btian) → review+

Comment 19

4 years ago
Comment on attachment 8475769 [details] [diff] [review]
[08] Bug 1050174: Use |SocketIOBase| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475769 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475769 - Flags: review?(btian) → review+

Comment 20

4 years ago
Comment on attachment 8475775 [details] [diff] [review]
[11] Bug 1050174: Use |SocketIOShutdownTask| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475775 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475775 - Flags: review?(btian) → review+

Comment 21

4 years ago
Comment on attachment 8475773 [details] [diff] [review]
[10] Bug 1050174: Use |SocketIOSendTask| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475773 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475773 - Flags: review?(btian) → review+

Comment 22

4 years ago
Comment on attachment 8475771 [details] [diff] [review]
[09] Bug 1050174: Use |SocketIOTask| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475771 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475771 - Flags: review?(btian) → review+

Comment 23

4 years ago
Comment on attachment 8475777 [details] [diff] [review]
[12] Bug 1050174: Cleanup interface of |BluetoothSocket| (under bluetoth2/)

Review of attachment 8475777 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475777 - Flags: review?(btian) → review+

Comment 24

4 years ago
Comment on attachment 8475759 [details] [diff] [review]
[02] Bug 1050174: Use |SocketConsumerBase| for Bluetooth sockets (under bluetooth2/)

Review of attachment 8475759 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8475759 - Flags: review?(btian) → review+

Comment 25

4 years ago
Comment on attachment 8475758 [details] [diff] [review]
[01] Bug 1050174: Cleanup fields in |DroidSocketImpl| (under bluetooth2/)

Review of attachment 8475758 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks for the effort!
Attachment #8475758 - Flags: review?(btian) → review+

Updated

4 years ago
Blocks: 1019376
You need to log in before you can comment on or make changes to this bug.