1050194 - When a contact is saved with phone number with <<pause>> and an user calls to this contact, in "call log" screen user can't see contact's name

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.1 
Gecko-8d0205c
Gaia-bea8355

Reproducible: 100%

Pre-requisites: Contact saved with name and phone number with <<pauses>>. For example: 655655655,,,6565,65,,,,656

STRs:
1.  Tap Contact application.
2. Tap in contact with pause in phone number.
3. Tap in phone number and make a call.
4. Call established.
5. Hung up call.
6. Tap Dialer application.
7. Tap in Call log screen.

Actual result:
User can't see contact's name in call log screen.

Expected result:
User can see contact name in call log screen.

Comment 1

[Jason Smith [:jsmith]]

QA Wanted for branch checks.

Comment 2

[Duane Dixon [:ddixon]]

Issue DOES reproduce in Flame 2.1 build.  

Device: Flame Master
Build ID: 20140810234109
Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5
Gecko: a9b43778f0c2
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-------------------------------------------------------------------------
-------------------------------------------------------------------------

Issue DOES NOT reproduce on Flame 2.0, 1.4, Buri 2.1, and is Blocked on Open_C 2.1

Device: Flame 2.0
Build ID: 20140811023109
Gaia: edaefce424b78505a82a79cc7a2b5eef9b5e53d3
Gecko: 7e808b6ae5b4
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-------------------------------------------------------------------------
Device: Flame 1.4
Build ID: 20140808033135
Gaia: 2b2849a61cd38e909ed1c3e4586d104bc96f7001
Gecko: 931bf8651711
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0
-------------------------------------------------------------------------
Device: Buri Master
Build ID: 20140808091209
Gaia: c97d1b6c3094e854377b6affa5f46b8d4b7316ce
Gecko: f40c3647561c
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-------------------------------------------------------------------------
Open_C is blocked due to an error screen "Unable to make a phone call now" which does not allow the call to be made, thus call cannot be logged. 

Device: Open_C Master
Build ID: 20140810234109
Gaia: 19ed3c9e78eaf234cc08484bde6998ae21552ba5
Gecko: a9b43778f0c2
Version: 34.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[Joshua Mitchell (Inactive)]

Qa-Triage - I'm not certain I would block on this issue. Adding pauses to contact numbers does not seem a typical-user action and if they do, issue is only visual within the call-log after calling that number.

Comment 4

[Jason Smith [:jsmith]]

So I've actually never been exposed to phone numbers in this format before.

Wilfred - Can you explain the product motivation behind these phone number formats? What target markets would care about these phone number phone formats?

Comment 5

[Wilfred Mathanaraj [:WDM]]

there are various scenarios like users who have a predefined menu they would like to navigate, people who use this setup for activating specific items, users who have to navigate a menu tree to top-up their SIM.

I can imagine this being a issue for those users who have made the call but do not see the name next to the item in the call log.  As a user I would always expect to see a name I have stored for a number in the call log.

Comment 6

[Jason Smith [:jsmith]]

I think we need more information on what is being seen on 2.0, as comment 2 doesn't really explain what's happening on 2.0.

Comment 7

[Duane Dixon [:ddixon]]

Attachment: Flame 2.0 correctly logs paused and unpaused numbers.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Duane Dixon [:ddixon] from comment #7)
> Created attachment 8476996 [details]
> Flame 2.0 correctly logs paused and unpaused numbers.

I don't understand this screenshot. The bug is talking about the fact that contact's name isn't being shown, which this screenshot is showing evidence of. Can we get this detail clarified & provide a screenshot of the 2.1 behavior?

Comment 9

[Duane Dixon [:ddixon]]

I apologize for the confusion.  I provided screenshots of the behavior displayed in the 2.1 and 2.0 branches.  

Flame 2.1 

Actual Results: Contact's name is NOT displayed in call log when the phone number contains pauses. 

Screenshot: "2.1_behavior.png"

Device: Flame Master
BuildID: 20140822010750
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: 0b9dd32d1e16
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
--------------------------------------------------
Flame 2.0 

Actual Results: Contact's name IS displayed correctly in call log when the phone number contains pauses.

Screenshot: "2.0_behavior.png"

Device: Flame 2.0
BuildID: 20140822100753
Gaia: 06edd086387c2150017b549e6318a61cd7e4fd02
Gecko: d946233724d5
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 10

[Duane Dixon [:ddixon]]

Attachment: 2.1_behavior.png

Comment 11

[Duane Dixon [:ddixon]]

Attachment: 2.0_behavior.png

Comment 12

[Jason Smith [:jsmith]]

Beatriz - Would a regression like this block certification?

Comment 13

[Beatriz Rodríguez [:brg]]

(In reply to Jason Smith [:jsmith] from comment #12)
> Beatriz - Would a regression like this block certification?
Yes, this is a bad resgression, please fix it.

Comment 14

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

Certification blocking regression

Comment 15

[Joshua Mitchell (Inactive)]

Loli - just want to make sure it's okay to steal QA-Contact from you, and verify you aren't working on the regression window for this (if you are, please disregard)

Comment 16

[Joshua Mitchell (Inactive)]

At this point is seems safe to assume this bug is 'up for grabs'

Comment 17

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last Working 

Device: Flame Master
BuildID: 20140707091925
Gaia: 46bad9d7f31cbc79a4551b011529156ba8f1f8c7
Gecko: 7cd417c9249e
Version: 33.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken 

Device: Flame Master
BuildID: 20140707114731
Gaia: 1dc9e53393ae4680a174dffa44a958ec564ebbe8
Gecko: 68c448557108
Version: 33.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: 46bad9d7f31cbc79a4551b011529156ba8f1f8c7
Gecko: 68c448557108

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 1dc9e53393ae4680a174dffa44a958ec564ebbe8
Gecko: 7cd417c9249e

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/46bad9d7f31cbc79a4551b011529156ba8f1f8c7...1dc9e53393ae4680a174dffa44a958ec564ebbe8

Possible Cause: 

Bug 1004973 - Unify MockL10n. r=julienw r=gandalf

Comment 18

[Joshua Mitchell (Inactive)]

Broken by Bug 1004973 ? Can you take a look Stas?

Comment 19

[Staś Małolepszy :stas]

Hey, I'll take another look when I buy a pre-paid SIM card this afternoon and try to reproduce.  How do I input numbers with pauses?  With a comma?

Also, my commit from bug 1004973 only touched tests in shared and apps/sms, so I'm not sure if that could be a reason.

Comment 20

[Duane Dixon [:ddixon]]

(In reply to Staś Małolepszy :stas from comment #19)
> Hey, I'll take another look when I buy a pre-paid SIM card this afternoon
> and try to reproduce.  How do I input numbers with pauses?  With a comma?
> 
> Also, my commit from bug 1004973 only touched tests in shared and apps/sms,
> so I'm not sure if that could be a reason.

To input a number with pauses: 
1. Open Contacts App. and add a Contact.
2. Tap on phone number field and add numbers and 'pauses'
3. Note that 'pauses' are either: ( or * depending on the branch.  

Example: 555*22*3  or 212((4545(1

Comment 21

[Staś Małolepszy :stas]

I wasn't able to check if it was my commit or not because the phone doesn't work with the commits from around July 2.  I might need a different version of Gecko.

Can we get some help from QA here?  Bisecting that pushlog from comment 17 would certainly help.

Like I said, I don't think my commit broke it:  it only touched unit tests.

Comment 22

[Jason Smith [:jsmith]]

Asking for regression window wanted again since I don't think the suspected patch is the cause of this regression.

Comment 23

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue occurs on the earliest available build we have that recognizes SIMs.

Environmental Variables:
Device: Flame Master
BuildID: 20140506163010
Gaia: 98ca8c55dbe2f21a8661d0eaa87f34d316c3bc98
Gecko: 4e4e0f502969
Version: 32.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 24

[Joshua Mitchell (Inactive)]

Stas - sorry for wasting your time - it appears your patches were not the regressors

Comment 25

[Loli (:lolimartinezcr)]

Now this bug isn't valid because feature has been backed out in 2.1, for this reason I close it "RESOLVED INVALID"

Comment 26

[Staś Małolepszy :stas]

(In reply to Joshua Mitchell [:Joshua_M] from comment #24)
> Stas - sorry for wasting your time - it appears your patches were not the
> regressors

No worries!  I'm always happy to help if I can :)