1050263 - Remove incorrect name reference from email subject when emailing a loop url

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

When bug 1000772 landed, it landed with the string:

share_email_subject=Loop invitation to chat

The "Loop" part shouldn't be in there. I'll be attaching a patch in a moment to fix this.

Comment 1

[Mark Banner (:standard8)]

Attachment: Remove incorrect name reference from email subject when emailing a loop url

This removes the "Loop " part, as suggested to me by mreavy.

Comment 2

[Darrin Henein [:darrin]]

Comment on attachment 8469253 [details] [diff] [review]
Remove incorrect name reference from email subject when emailing a loop url

Looks good to me! We may want to have marketing look at this as well.

Comment 3

[Maire Reavy [:mreavy]]

The main goal is to remove the "Loop" name.   Arcadio -- I need a fast reply so that we can check this in today and then uplift the email button (along with few other requested changes) to Aurora tomorrow/ by Monday.  Thanks!

Comment 4

[Maire Reavy [:mreavy]]

Comment on attachment 8469253 [details] [diff] [review]
Remove incorrect name reference from email subject when emailing a loop url

Review of attachment 8469253 [details] [diff] [review]:
-----------------------------------------------------------------

Just talked to Arcadio -- ui-review+ via irc.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f478a95ef92d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f478a95ef92d

Comment 7

[u279076]

Does this need manual testing or is it sufficiently covered by automation?

Comment 8

[Paul Silaghi, QA [:pauly]]

Now it's saying: "You have been invited to a conversation".
Verified fixed 34.0a1 (2014-09-02) Win 7 x64.

Comment 9

[u279076]

Thanks Paul.