Closed Bug 1050291 Opened 7 years ago Closed 7 years ago

ARM Simulator: fix vmovl quad register encoding.

Categories

(Core :: JavaScript Engine: JIT, defect)

ARM
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: dougc, Assigned: dougc)

Details

Attachments

(1 file, 1 obsolete file)

Noticed an upstream fix for the vmovl quad register encoding that we may need soon for the SIMD work, see: https://codereview.chromium.org/207523005/
Attachment #8469285 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8469285 [details] [diff] [review]
Fix vmovl quad register encoding.

Review of attachment 8469285 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/arm/Simulator-arm.cpp
@@ +3862,5 @@
>        case 5:
>          if (instr->bits(18, 16) == 0 && instr->bits(11, 6) == 0x28 && instr->bit(4) == 1) {
>              // vmovl signed
> +            if ((instr->vdValue() & 1) != 0)
> +                MOZ_CRASH();

nit: MOZ_CRASH("Undefined behavior");

@@ +3887,5 @@
>        case 7:
>          if (instr->bits(18, 16) == 0 && instr->bits(11, 6) == 0x28 && instr->bit(4) == 1) {
>              // vmovl unsigned.
> +            if ((instr->vdValue() & 1) != 0)
> +                MOZ_CRASH();

nit: same here.
Attachment #8469285 - Flags: review?(nicolas.b.pierron) → review+
Thank you for the quick review. Addressing reviewer feedback. Carrying forward r+.
Attachment #8469285 - Attachment is obsolete: true
Attachment #8469689 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/033f817bc414
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.