Closed Bug 1050309 Opened 10 years ago Closed 10 years ago

Support RTL mode in the panel

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

(firefox34 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla34
Iteration:
34.3
Tracking Flags:
Tracking Status
firefox34 --- verified

People

(Reporter: mikedeboer, Assigned: jaws)

References

Details

Attachments

(1 file, 2 obsolete files)

Patch v2.1
2.43 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
At the moment, when using an RTL language distribution of Fx, the UI does not adhere to this locale and displays elements and text as in LTR mode.

To force RTL mode when developing: https://addons.mozilla.org/en-US/firefox/addon/force-rtl/
Whiteboard: p=2
Flags: firefox-backlog+
OS: Mac OS X → All
Hardware: x86 → All
Points: --- → 2
Whiteboard: p=2 → [qa?]
Whiteboard: [qa?] → [qa+]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 34.3
Iteration: 34.3 → ---
Flags: qe-verify+
Whiteboard: [qa+]
Status: ASSIGNED → NEW
Attached patch Patch (obsolete) — — Splinter Review 

        Attachment #8477598 -
        Flags: review?(adam)
Status: NEW → ASSIGNED
Iteration: --- → 34.3

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2 (obsolete)
        — 
          — Splinter Review
      

    


  
Removed the locale string and now using mozL10n.getDirection.

        Attachment #8477598 -
        Attachment is obsolete: true

        Attachment #8477598 -
        Flags: review?(adam)

        Attachment #8478039 -
        Flags: review?(adam)

    
    

    
  
Comment on attachment 8478039 [details] [diff] [review]
Patch v2

This needs to change panel.jsx as well...

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2.1
        — 
          — Splinter Review
      

    


  
With panel.jsx changed.

        Attachment #8478039 -
        Attachment is obsolete: true

        Attachment #8478039 -
        Flags: review?(adam)

        Attachment #8478337 -
        Flags: review?(standard8)
QA Contact: anthony.s.hughes

    
    

    
  
Comment on attachment 8478337 [details] [diff] [review]
Patch v2.1

Review of attachment 8478337 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r=Standard8

        Attachment #8478337 -
        Flags: review?(standard8) → review+
Iteration: 34.3 → 35.1

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4d0a886d3c22
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla34
Iteration: 35.1 → 34.3

    
    

    
  
Paul, can you please do some basic dogfooding of Loop with some RTL locales to confirm everything looks and functions properly? If so, lets mark this verified fixed.

Thanks
Flags: needinfo?(paul.silaghi)

    
  
QA Contact: anthony.s.hughes → paul.silaghi

    
    

    
  
Is the colon position ok in the title  - ":Share this link to invite someone to talk" ?
Flags: needinfo?(paul.silaghi) → needinfo?(jaws)

    
    

    
  
(In reply to Paul Silaghi, QA [:pauly] from comment #9)
> Is the colon position ok in the title  - ":Share this link to invite someone
> to talk" ?

Yes, that is because you're using English as your RTL language (which it isn't ;) ). If you used a real RTL language it wouldn't be awkward.
Flags: needinfo?(jaws)

    
    

    
  
Thanks Jared, one more question:
34.0a1 (2014-09-02) AR, Win 7 x64:
http://i.imgur.com/l8sCCcb.png?1
http://i.imgur.com/3YBVfP9.png?1
Please say which are real issues and I should file separately (forget about the first one).
Flags: needinfo?(jaws)

    
    

    
  
1 is working as expected. 2,3,4,5,6 should have bugs filed.
Flags: needinfo?(jaws)

    
    

    
  
To be clear, 3,4,5,6 were not part of this bug since they are not in the panel.
Depends on: 1062834

    
    

    
  
Filed bug 1062834, 1062835, 1062836, 1062838, 1062839 for the remaining issues.
Marking this one as verified fixed 34.0a1.
Status: RESOLVED → VERIFIED

          status-firefox34:
          --- → verified

    
  
Depends on: 1062838

    
  
Depends on: 1062836

    
  
No longer depends on: 1062836

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: