1050339 - [B2G][Smart Collections] Default Smart Collections are missing their icons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: log.txt

Description:
The Smart Collections icons are not displayed correctly.

Repro Steps:
1) Update a Flame device to BuildID: 20140807000201
2) Proceed through the FTU

Actual:
The Smart Collections icons are not displayed correctly.

Expected: 
The Smart Collections are displayed correctly.
  
Environmental Variables:
Device: Flame 2.0 319MB
BuildID: 20140807000201
Gaia: 8cc28fd31905a0ea2b2e15d13e80a0eab2feb1ba
Gecko: 25980b5120b0
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
  
Notes:
Repro frequency: 100%
See attached: screenshot, logcat

Comment 1

[Josh Schmitt [Joshs]]

Attachment: Smart_Collections.png

Comment 2

[Josh Schmitt [Joshs]]

Enviromental Variables:
----------------------------------------
Device: Flame 2.1 319MB and 512MB
BuildID: 20140807040201
Gaia: 079c5f85875b0f2eb341ca9fd375f1b905ed7157
Gecko: afcb3af79d09
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Flame 2.0 319MB and 512MB
BuildID: 20140807000201
Gaia: 8cc28fd31905a0ea2b2e15d13e80a0eab2feb1ba
Gecko: 25980b5120b0
Version: 32.0 (2.0)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Smoketest Regression of a core feature.  This issue was reproduced while flashing.

Requesting a window.

Comment 4

[Joshua Mitchell (Inactive)]

Mozilla-Central Regression Window:

Last Working:
Device: Flame Master
Build ID: 20140806134618
Gaia: 5e6ef81cb9e917657ce050f598229dfc83c58b8f
Gecko: a31cd48facbf
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame Master
Build ID: 20140806165814
Gaia: 079c5f85875b0f2eb341ca9fd375f1b905ed7157
Gecko: 16569cf5ffa5
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 5e6ef81cb9e917657ce050f598229dfc83c58b8f
Gecko: 16569cf5ffa5

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 079c5f85875b0f2eb341ca9fd375f1b905ed7157
Gecko: a31cd48facbf

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/5e6ef81cb9e917657ce050f598229dfc83c58b8f...079c5f85875b0f2eb341ca9fd375f1b905ed7157

B2G-Inbound Regression Window: 
Last Working:
Device: Flame Master
Build ID: 20140806082820
Gaia: 2e2d3263b39ffcef8e1d2d200ce461245b97ebec
Gecko: b5c072f24e08
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame Master
Build ID: 20140806085958
Gaia: 256cb6bff259ba4552b0c3d4f0b4d4e72452843c
Gecko: 280ab9072d97
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 2e2d3263b39ffcef8e1d2d200ce461245b97ebec
Gecko: 280ab9072d97

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 256cb6bff259ba4552b0c3d4f0b4d4e72452843c
Gecko:b5c072f24e08

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/2e2d3263b39ffcef8e1d2d200ce461245b97ebec...256cb6bff259ba4552b0c3d4f0b4d4e72452843c

Comment 5

[Joshua Mitchell (Inactive)]

Broken by Bug 1045701 - Kevin, can you take a look?

Comment 7

[Kevin Grandon :kgrandon]

Attachment: Github pull request

This is indeed fallout over part of bug 1045701. We fixed the OTA update but broke normal flashing for devices with pixel density, fun. Because we only ever build with a single collection icon - let's just rename it to make sure we don't have any weird edge cases.

Amir or Yuren - could you guys take a look? Thanks!

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8469530 [details] [review]
Github pull request

r=yurenju if nit is addressed.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8469530 [details] [review]
Github pull request

Thanks Yuren. Made an update with the test. Going to clear Amir's review now to get this in - Amir feel free to leave any comments if you have them.

Comment 10

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/fb47799fab6dfc43b4af0baeb00df55e58657941

Comment 11

[Kevin Grandon :kgrandon]

The patch here is also required to fix a 2.0 blocker (bug 1045701), so uplifting.

2.0: https://github.com/mozilla-b2g/gaia/commit/1144cdc3a544f81c9bf71598aba1cb67d6c95a29

Comment 12

[Martin Shuman [:Marty]]

Verified Fixed.
Issue no longer occurs on Flame 2.0 or 2.1

Environmental Variables:
Device: Flame 2.0
Build ID: 20140812000205
Gaia: 1144cdc3a544f81c9bf71598aba1cb67d6c95a29
Gecko: 6495a7bd61ed
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame Master
Build ID: 20140812040201
Gaia: e78e62125eb43c3a28cdc047987ba54430694a2f
Gecko: b53c2753ce9a
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0