Closed
Bug 1050396
Opened 11 years ago
Closed 11 years ago
Cancel timer for ring command when stopping due to zero duration
Categories
(Firefox OS Graveyard :: FindMyDevice, defect)
Firefox OS Graveyard
FindMyDevice
Tracking
(blocking-b2g:2.1+, b2g-v2.1 fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: ggp, Assigned: ggp)
Details
Attachments
(1 file)
The ring command is supposed to stop ringing when it receives a duration parameter equal to zero, if it's already ringing. However, when we do that, we don't cancel timeout that controls when to stop ringing.
This is a low priority issue, since the server currently never sends zero for the duration, but it will in the future. It's also a good opportunity to refactor some of the tests for ring.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8469416 -
Flags: review?(lissyx+mozillians)
|
||
Updated•11 years ago
|
blocking-b2g: --- → 2.1+
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8469416 [details] [review]
gaia pull request
This all looks good. I left a comment on github, regarding potential async in test. You can land this once you address this comment :)
Attachment #8469416 -
Flags: review?(lissyx+mozillians) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•