10504 - [blocker] Sending a message doesn't send the body

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[scottputterman]

Open up an HTML message compose window (haven't tried this on plain text).  Type
in a message into the body.  Send it.  When you get it, the message will not
have the body.

Comment 1

[rhp (gone)]

Waiting on a clobber build and will investigate to see what is going on.

- rhp

Comment 2

[rhp (gone)]

ok, it looks like everything is ok in the compose back end, but we are failing
on  the call to:  GetContentAs()

Here is the code leading up to the call:

  //
  // Query the editor, get the body of HTML!
  //
  nsString  format(TEXT_HTML);
  PRUint32  flags = 0;
  PRUnichar *bodyText = NULL;

  // Ok, get the body...the DOM should have been whacked with
  // Content ID's already
  mEditor->GetContentsAs(format.GetUnicode(), flags, &bodyText);


I traced into this further and we eventually get to a call WillDoAction and we
immediately return with a failure because aSelection is NULL. Here is the check
that fails:

NS_IMETHODIMP
nsHTMLEditRules::WillDoAction(nsIDOMSelection *aSelection,
                              nsRulesInfo *aInfo, PRBool *aCancel)
{
  if (!aSelection || !aInfo || !aCancel)
    return NS_ERROR_NULL_POINTER;

Not sure what to do from here so reassigning to akkana for some help.

- rhp

Comment 3

[Akkana Peck]

Rich, Steve and I tracked down the problem and Rich has checked in a fix.
Here's what happened: Steve noticed a bug in the text edit rules where
WillDoAction required the selection to be set even for routines (like getting
the whole document output) which don't need it).  He also noticed that
nsTextEditor::OutputToString was ignoring the result of WillDoAction.  He fixed
both of these problems.  The problem was that the html edit rules still had the
first bug (requiring the selection), so nsHTMLEditor::OutputToString (which just
calls the text editor version, but with html edit rules) was failing.  The fix
was to make the corresponding fix to the html edit rules, to not require a
selection.

Comment 4

[lchiang]

esther - can you verify?  Thanks.

Comment 5

[esther]

Using 19990816 builds on win32, linux and Mac (note this was Ninoschka's Mac),
and using the scenario provided, this is fixed.  The message received is not
blank.  We sent text with no html attributtes in the body using a html compose
window and text with html in body using the html compose window, both worked OK.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e2bcdecf2d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Creates the TabTrayDialogFragment
https://hg.mozilla.org/integration/autoland/rev/ab354397651c
[fenix] For 10504 - Adds dialog style and fab
https://hg.mozilla.org/integration/autoland/rev/d1a4e7df9c38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions
https://hg.mozilla.org/integration/autoland/rev/87f11f560905
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Adds padding fto account for navigation bar in landscape
https://hg.mozilla.org/integration/autoland/rev/baba08c5f248
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Fixes up tab tray dialog styles
https://hg.mozilla.org/integration/autoland/rev/d7ebfc46a8ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Show tab dialog on browserfragment
https://hg.mozilla.org/integration/autoland/rev/b48ee326ec1f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Adds tabTrayDialogInteractor to browserfragment
https://hg.mozilla.org/integration/autoland/rev/7f33f6d6d776
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - cleans up tabLayout colors
https://hg.mozilla.org/integration/autoland/rev/5bad4239e8e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - opens the tab tray and filters the tab based on the browser mode
https://hg.mozilla.org/integration/autoland/rev/3ed042ef5650
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Removes "old" TabTrayFragment