1050408 - devicemanager calls "warn" on a structured logger

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

Devicemanager uses "warn" for logging in a few places: 

testing/mozbase/mozdevice/mozdevice/devicemanager.py:88:        self._logger.warn("dm.debug is deprecated. Use logLevel.")
testing/mozbase/mozdevice/mozdevice/devicemanager.py:95:        self._logger.warn("dm.debug is deprecated. Use logLevel.")
testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py:483:            self._logger.warn("process %s appears to be running already\n" % appname)
testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py:517:            self._logger.warn("launchProcess called without command to run")
testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py:551:                    self._logger.warn("unable to kill -%d %s (pid %s)" %
testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py:556:                self._logger.warn("unable to kill -%d %s -- not running?" %
testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py:567:                    self._logger.warn("try %d of %d failed to kill %s" %
testing/mozbase/mozdevice/mozdevice/devicemanagerSUT.py:929:            self._logger.warn("unable to adjust screen resolution on non Tegra device")

At least some of these are calls to a structured logger, which has no warn method. We either need to add "warn" to structuredlog.py or convert these to use "warning".

Comment 1

[James Graham [:jgraham]]

Attachment: Remove uses of logging.warn from DeviceManager, r=wlach

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8469968 [details] [diff] [review]
Remove uses of logging.warn from DeviceManager, r=wlach

Review of attachment 8469968 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, could you also consider making the structured logger support "warn" as an alias for "warning". This will help facilitate converting code from using either mozlog or old-style python logging to structured logging.

Comment 3

[James Graham [:jgraham]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/539e4e94e400

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/539e4e94e400