Closed Bug 1050509 Opened 8 years ago Closed 8 years ago

Shut down KeyStore properly

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S2 (15aug)

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Keywords: memory-leak, Whiteboard: [MemShrink:P2])

Attachments

(1 file)

Attached patch PatchSplinter Review
to avoid leaking.
Attachment #8469579 - Flags: review?(tzimmermann)
Comment on attachment 8469579 [details] [diff] [review]
Patch

Review of attachment 8469579 [details] [diff] [review]:
-----------------------------------------------------------------

The commit message could be improved, but the patch is good. Thanks for fixing the cleanup and shutdown code.
Attachment #8469579 - Flags: review?(tzimmermann) → review+
That's fair.  I changed it to

Bug 1050509: Shut down the KeyStore socket during system shutdown to avoid leaks. r=tdz 

https://hg.mozilla.org/integration/b2g-inbound/rev/b7435ce126ab
https://hg.mozilla.org/mozilla-central/rev/b7435ce126ab
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in before you can comment on or make changes to this bug.