1050529 - When screen reader is toggled off the a11y panel disappears

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Enable a11y panel in settings
2. Toggle screen reader on via panel.
3. Toggle screen reader off.

Results: a11y panel goes away.
Expected: a11y panel should remain once it is enabled.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22646

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22646#issuecomment-51537051

This is how I think the behavior should be. I think the previous patch misunderstood the purpose for this, which is to show the panel permanently once the user starts toying with the screen reader.

Comment 3

[Alexey Novak]

This use case you provided makes sense.

I think there should be 2 type of settings in accessibility.js One type is responsible for showing/hiding a11y panel through Show Accessibility settings ON/OFF. Another one is responsible for switching accessibility.screenreader setting ON/OFF. Basically whenever one of those settings is ON then the a11y panel should be present. But ONLY when Show Accessibility settings are set to OFF then we hide the a11y panel.

What do you think about this?

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8469616 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22646#issuecomment-51537051

I like this.

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to Alexey Novak from comment #3)
> This use case you provided makes sense.
> 
> I think there should be 2 type of settings in accessibility.js One type is
> responsible for showing/hiding a11y panel through Show Accessibility
> settings ON/OFF. Another one is responsible for switching
> accessibility.screenreader setting ON/OFF. Basically whenever one of those
> settings is ON then the a11y panel should be present. But ONLY when Show
> Accessibility settings are set to OFF then we hide the a11y panel.
> 
> What do you think about this?

I think the patch I submitted has a similar effect and is pretty straight forward. If the screen reader is activated (no matter how), make sure the panel is showing, and don't hide it again unless the user goes into dev settings and disables it.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/9062a9a2de50d56ddba733d23b90993d3a276457