1050545 - [Camera] switching to video mode often sets focus in the lower right

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[David Flanagan [:djf]]

On my Flame, on master (but not in 2.0) when I tap on the slider to switch from photo to video mode, I usually also set the focus region to the lower-right of the viewfinder.  In 2.0 tapping in the region around the mode switch does not set the focus, but it does in 2.1.

Comment 1

[David Flanagan [:djf]]

This is a regression and I think we should be sure to fix it for 2.1.

Diego: since you did touch focus, I'm guessing that you're probably the right person to take this bug.

Comment 2

[Diego Marcos [:dmarcos]]

This is probably because we are letting the events go through to the viewfinder while before (2.0) we were stopping propagation somewhere in the controls bar in the bottom. I will see what has changed. Probably a CSS change or removal of a stopPropagation() call introduced the regression.

Comment 3

[Joshua Mitchell (Inactive)]

additionally - once you encounter this bug and slide the slider back to picture, it will continue to focus in the bottom right corner and so-on each time you slide the slider.

Comment 4

[Joshua Mitchell (Inactive)]

Mozilla Central Regression Window:

Last Working:
Device: Flame Master
Build ID: 20140730141509
Gaia: b67ddd7d40b52e65199478b8d6631c2c28fdf41d
Gecko: 005424a764da
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame Master
Build ID: 20140731040408
Gaia: 6548f8a89654727eb3a65200ef14298e106eb099
Gecko: ef1a3ed657fc
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: b67ddd7d40b52e65199478b8d6631c2c28fdf41d
Gecko: ef1a3ed657fc

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 6548f8a89654727eb3a65200ef14298e106eb099
Gecko: 005424a764da

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/commit/3ea3a35aa58cf256b1f6bc76e299c71ca55bcf2a


Normally I would do a secondary window to tighten-up the pushlog but I think it's pretty clear that this was caused by bug 1046316 which seems to corroborate what Diego was saying in comment 2

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/22828

Hi Wilson,
   I found |js-switch| used |onButtonClick| to avoid to propagate event on v2.0[1], seems it does not avoid propagation after using |drag| module [2] on master.

  This is my quick patch, could you give me some feedback and guide me how to patch |drag| module.

  Thanks.



   [1] https://github.com/mozilla-b2g/gaia/blob/v2.0/apps/camera/js/views/controls.js#L37
   [2] https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/views/controls.js#L11

Comment 6

[Diego Marcos [:dmarcos]]

Gary, Wilson will give you feedback on the patch but you have to submit the PR to the repository where the drag module lives:

https://github.com/gaia-components/drag

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Okay!!
Thanks Diego~

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/gaia-components/drag/pull/2

Hi Wilson,
   According to Diego's suggestion, I've separated 2 patches.
   Please help to review patches and give me some feedback.

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8473525 [details] [review]
pull request: https://github.com/gaia-components/drag/pull/2

LANDED (master) https://github.com/gaia-components/drag/commit/cd84fd03a2a408f05c59ef1212bfb8f1499c4398

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8473525 [details] [review]
pull request: https://github.com/gaia-components/drag/pull/2

Released Drag v0.1.1 https://github.com/gaia-components/drag/releases/tag/v0.1.1

Comment 11

[Wilson Page [:wilsonpage]]

Comment on attachment 8472240 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/22828

Looks good!

Comment 12

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8472240 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/22828

Hi Wilson,
   Sorry interrupt you again, I just rebase my patch without changing anything.
   Could you help to grant my patch? 
   Thanks.

Comment 13

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

landed in master,
https://github.com/mozilla-b2g/gaia/commit/2054e40986e4da655f2518f8cc2d84922029b0b8

Comment 14

[John Thomas [:Johnt]]

This issue does NOT occur on the Flame 2.1 KK (319mb)

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Switching to video mode does not set focus in the lower right