Closed
Bug 1050558
(Bosnian-WordPrediction)
Opened 10 years ago
Closed 10 years ago
Bosnian Word suggestion
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)
People
(Reporter: delphine, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(2 files)
3.90 MB,
application/xml
|
Details | |
46 bytes,
text/x-github-pull-request
|
timdream
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
Kevin: we were told that using a Croatian word suggestion for a device in Bosnian is acceptable. Can you please let us know what you think about this? If this is in fact not the case, could you help work on an appropriate word list for Bosnian? thanks!
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(kscanne)
Comment 1•10 years ago
|
||
Acceptable but not optimal. I did some work on the primary open source Bosnian spell checker a few years ago - the coverage is pretty good and I can collect some texts from .ba domains to add frequencies to that. I'll be travelling the next two weeks but I can look at it after that - is there a deadline? Also, who is the Bosnian localizer working on Firefox OS (in case I have questions)?
Flags: needinfo?(kscanne)
Reporter | ||
Comment 2•10 years ago
|
||
Thanks for your answer Kevin! Not really sure about deadlines, but taking a look in 2 weeks should be fine! CCing Kerim as well, the Bosnian localizer
Comment 3•10 years ago
|
||
Both Croatian and Serbian are similar but none of them is good enough. I am happy to help with creating a Bosnian spell checker. Just let me know what you need from me ;)
Reporter | ||
Comment 4•10 years ago
|
||
Cool, thanks Kerim! Can anyone here give Kerim some tips about how he can help with this? Not sure what the steps would be here.
Comment 5•10 years ago
|
||
The major thing we need is the wordlist, plus frequency, in this format (freq between 1 and 255, profane words marked as f=0): https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/latin/dictionaries/en_us_wordlist.xml Everything else is trivial.
Flags: needinfo?(kerim)
Comment 6•10 years ago
|
||
Kerim and I are corresponding about this - will report back when we've made some progress.
Reporter | ||
Comment 7•10 years ago
|
||
[Blocking Requested - why for this release]: Marking this as blocker as Bosnian is required for 2.1
blocking-b2g: --- → 2.1?
Updated•10 years ago
|
Assignee: nobody → rlu
blocking-b2g: 2.1? → 2.1+
Assignee | ||
Updated•10 years ago
|
Priority: -- → P1
Target Milestone: --- → 2.1 S3 (29aug)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=1]
Comment 9•10 years ago
|
||
Kerim is editing some words - when that's done I'll be able to turn the word list around pretty quickly.
Flags: needinfo?(kscanne)
Comment 10•10 years ago
|
||
Hi Kerim, is the word editing done yet? Thanks.
Comment 11•10 years ago
|
||
Kerim finished the editing, and I've built the attached frequency list based on a ~15 million word corpus.
Flags: needinfo?(kerim)
Assignee | ||
Updated•10 years ago
|
Target Milestone: 2.1 S3 (29aug) → 2.1 S5 (26sep)
Assignee | ||
Comment 12•10 years ago
|
||
The patch to add the wordlist and the compiled dictionary. Jan, could you help review this? Kevin, Kerim, Thanks for your support to provide the wordlist!
Attachment #8493515 -
Flags: review?(janjongboom)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8493515 [details] [review] Patch V1 Seems Jan cannot get to review this. Tim, could you please help to review it, since it is a 2.1+ blocker? Thank you.
Attachment #8493515 -
Flags: review?(timdream)
Updated•10 years ago
|
Attachment #8493515 -
Flags: review?(timdream)
Attachment #8493515 -
Flags: review?(janjongboom)
Attachment #8493515 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/1b2d22eefd30944465437d1834f723f6995a96c4 -- Thanks!
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8493515 [details] [review] Patch V1 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): This is a feature to add autocorrection for Bosnian language. [User impact] if declined: No autocorrection/suggestion for Bosnian. [Testing completed]: Yes, manually. [Risk to taking this patch] (and alternatives if risky): no, the patch is simply adding a dictionary of Bosnian. [String changes made]: N/A
Attachment #8493515 -
Flags: approval-gaia-v2.1?
Updated•10 years ago
|
Attachment #8493515 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Reporter | ||
Comment 16•10 years ago
|
||
Just a quick heads up that we're going to start testing Bosnian on 2.1 this upcoming Monday, so would be nice to have this pretty quickly. I see you're on it but want to make extra sure :) Thanks!
Comment 17•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/d4672e065752e4cf38e277ed515af21f66a1f134
status-b2g-v2.1:
--- → fixed
Comment 18•10 years ago
|
||
What's the easiest way to test the Bosnian locale?
Reporter | ||
Comment 19•10 years ago
|
||
Hi Kerim. QAnalyst testers will start testing Bosnian tomorrow (Monday - PST time) on 2.1. If you would like to participate in this testing please let me know. In any case, they will CC you on the bugs they find, so that you can go and correct them. Feel free to reach out to me by email for more information!
Comment 20•10 years ago
|
||
This issue is verified fixed on Flame 2.2 and 2.1: Bosnian word suggestion and autocorrection work properly with Bosnian keyboard. Flame 2.2 Device: Flame 2.2 Master KK (319mb, Full Flash) BuildID: 20141022040201 Gaia: db7720c2ff58fdba6ae59595329e63c719ecb63f Gecko: ae4d9b4ff2ee Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 36.0a1 (2.2 Master) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 Flame 2.1 Device: Flame 2.1 KK (319mb, Full Flash) BuildID: 20141022001201 Gaia: 734d3547fb6c65e8bc4dd1a52b26f70bdfee7474 Gecko: 928b18f7d8ff Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 34.0 (2.1) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Reporter | ||
Updated•9 years ago
|
Blocks: WordPrediction
Reporter | ||
Updated•9 years ago
|
Alias: Bosnian-WordPrediction
You need to log in
before you can comment on or make changes to this bug.
Description
•