1050559 - Need typography quotes in keyboards

Status: RESOLVED DUPLICATE of bug 1053672

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Try to type typography quotes like “ ” ‘ ’

Expected:

You can.

Actual:

You can't.

I think we should put these chars on alternatives menu to the double quote key or the single quote key. Flagging Omega for opinion and spec update.

Comment 1

[Omega Feng [:Omega] [:馮於懋]]

That's a good idea.
I've just updated the spec in bug 983043.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

For default symbol panel, we need to modify apps/keyboard/js/keyboard/layout_loader.js.
Besides, we may need to go through each layout in js/layouts and modify it if it has customized "alternateLayout".

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks guys!

Comment 4

[Bruno Lima]

Hi, I'm new here and would like to help fixing this bug. Rudy Lu please assign to me this bug.

Thanks!

Comment 5

[Abin Abraham]

I am working on this bug on this bug as a part of Mozilla Kerala community Boot Camp .please assign this bug to me

Comment 6

[Rigin Oommen]

Please Specify the OS VERSION

Comment 7

[Abin Abraham]

Keyboards.symbolLayout = {//long press ' to choose  typography quotes in keyboards bug Bug 1050559 
  keys: [
    [
      { value: '‘'[
      { value: 'Alt', ratio: 1.2, keyCode: KeyEvent.DOM_VK_ALT },
      { value: '’' },
      { value: '⌫', ratio: 1.2, keyCode: KeyEvent.DOM_VK_BACK_SPACE }
    ], }, { value: '~' }, { value: '_' }, { value: '^' },
      { value: '±' }, { value: '|' }, { value: '[' }, { value: ']' },
      { value: '{' }, { value: '}' }
    ],

//this is solved for typography quotes ‘ ’

Comment 8

[Yuan Xulei [:yxl] (Leave from May 18)]

Abin and Bruno want to take this :-) Set needinfo in case you don't aware of it.

Comment 9

[Rabbi Hossain]

What about using (“) & {”) as an alternative of (") and  (‘) & (’) as an alternative of (')? 

Is there anyone working on this bug?

Comment 10

[Yuan Xulei [:yxl] (Leave from May 18)]

Please refer to comment 8.

Comment 11

[Abin Abraham]

Yuan Xulei[:yxl] please assigning this bug to me.i am working on it..

i don't think changing keyboard layout is a good option,instead we can implement in as the method which i have mentioned above comment 7 ...

Comment 12

[Abin Abraham]

(In reply to Abin Abraham from comment #11)
> Yuan Xulei[:yxl] please assigning this bug to me.i am working on it..
> 
> i don't think changing keyboard layout is a good option,instead we can
> implement in as the method which i have mentioned above comment 7 ...

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please see https://bug983043.bugzilla.mozilla.org/attachment.cgi?id=8471317#18 for spec.

The spec states exactly what comment 9 suggests.

Comment 14

[justine.lam]

Attachment: patch.diff

Hi, I'm Justine. I'm a newb to OSS, this is my first bug fix. Let me know if I need to change anything. Thanks! :)

Comment 15

[justine.lam]

Comment on attachment 8474152 [details] [diff] [review]
patch.diff

Oops! Posted this for the wrong bug. Please delete and disregard this.

Comment 16

[Abin Abraham]

Attachment: keyboard.js

please review the keyboard.js file

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8474159 [details]
keyboard.js

Please follow the steps here

https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch

to create a pull request for review. Thanks!

Comment 18

[Abin Abraham]

Review completed and bug is fixed and merged 

..

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Please take a look at comment 17 and submit a pull request based on the lastest master branch.
Thanks.

Comment 20

[Abin Abraham]

Bug is fixed and the code has been merged ([gaia] bug 1050559 fixed (#22953))..

Comment 21

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I don't see https://github.com/mozilla-b2g/gaia/pull/22953 is being merged nor reviewed. Also, that pull request has no line changes.

Comment 22

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The right way to ask for review is documented here:

https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch

Abin, do you still want to work on this bug?

Comment 23

[Tim Guan-tin Chien [:timdream] (please needinfo)]

dup of your fixed bug?