Closed Bug 1050583 Opened 11 years ago Closed 11 years ago

Add-on submission silently fails, or silently succeeds, when attempting to upload sources with incorrect extension

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Product:
addons.mozilla.org Graveyard
Component:
Admin/Editor Tools
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kmag, Assigned: yboniface)

References

Details

(Whiteboard: [ReviewTeam])

When attempting to upload a new extension, attaching sources with an unsupported extension causes the submission process to return to step 2, but without any message indicating what went wrong. When attempting to upload a new extension version, attaching sources with an unsupported extension causes the submission to silently succeed, but without any sources having been uploaded.
Good catch Kris! :) I'm on it: https://github.com/mozilla/olympia/pull/197
Assignee: nobody → yboniface
Fixed through https://github.com/yohanboniface/olympia/commit/bfb2f3c05ce269f55fdc9ecc96d45e43d0dd82b8 Kris, can I let you test again and change the status to fixed if it's ok for you?
This looks good, aside from https://github.com/mozilla/olympia/pull/197/files#diff-edd128b1c5b39036f1c5bc96018a6f5aR359
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.