Closed
Bug 1050599
Opened 10 years ago
Closed 10 years ago
Clean up GL Extension list
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: u480271, Assigned: u480271)
References
Details
Attachments
(1 file)
|
10.85 KB,
patch
|
bjacob
:
review+
jgilbert
:
feedback+
|
Details | Diff | Splinter Review |
The list of GL extensions that checked for are maintained in an unsorted list of enums and strings. When adding a new extensions, this makes it hard to visually scan the list to see if an extension is already being checked for.
M-x sort-lines on enum and strings.
Attachment #8469712 -
Flags: review?(bjacob)
Attachment #8469712 -
Flags: feedback?(jgilbert)
|
||
Updated•10 years ago
|
Attachment #8469712 -
Flags: feedback?(jgilbert) → feedback+
|
||
Comment 2•10 years ago
|
||
What about adding an assert(strcmp(sExtensionNames[i], sExtensionNames[i + 1]) < 0) ?
|
||
Updated•10 years ago
|
Attachment #8469712 -
Flags: review?(bjacob) → review+
https://tbpl.mozilla.org/?tree=Try&rev=e1c28e8ec813 So far try looks good.
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e38024ecc133
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•