Closed Bug 1050670 Opened 5 years ago Closed 5 years ago

verify output files from jsmin

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gduan, Assigned: gduan)

References

Details

Attachments

(2 files)

PR to master
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
PR to master 2
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review 
We should verify output files of jsmin.
Assignee: nobody → gduan
No longer depends on: 987487
Comment on attachment 8470590 [details] [review]
PR to master

Hi Yuren,
could you review this patch for me?
Thanks.
Attachment #8470590 - Flags: review?(yurenju.mozilla)
Comment on attachment 8470590 [details] [review]
PR to master

great! r=yurenju if nit is addressed
Attachment #8470590 - Flags: review?(yurenju.mozilla) → review+
Thanks Yuren!
master: https://github.com/mozilla-b2g/gaia/commit/2486e9d1da05d4938ae20db0bb810d0db26cc01a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
revert it, since travis is all red
https://github.com/mozilla-b2g/gaia/commit/4ae894f949c526f61bb827755de322afca096a12
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file PR to master 2 — 
waiting for test result.
Comment on attachment 8474250 [details] [review]
PR to master 2

Hi Yuren,
I've run build-test-unit in local and it works fine. Please help me to review it again. Thanks.
Attachment #8474250 - Flags: review?(yurenju.mozilla)
Hi George, 

could you run it on travis by your travis account? it has been reported which have some issues on travis.
Flags: needinfo?(gduan)
The failing reason is that I forgot to modify related unit test for webapp-optimize.js in previous patch.

Here's the new test result from travis. (bug 1054822 is going to fix the failing build test).
https://travis-ci.org/cctuan/gaia/builds/32824948
Flags: needinfo?(gduan)
Attachment #8474250 - Flags: review?(yurenju.mozilla) → review+
Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/91d0ff497c67deedcf5d7f2207c28b78731743d1
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.