Closed Bug 1050682 Opened 8 years ago Closed 8 years ago

[Messages] The recipient container will remain multiline style when removing the last recipient from opened panel

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 verified)

VERIFIED FIXED
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: lchang, Assigned: lchang)

References

Details

Attachments

(2 files)

Gaia Revision: 63422178f24a6fede5124c3f9184c0fc9f9c8a6b

STR:

1. launch messages app
2. create a new message
3. add at least 2 recipients
4. expand the recipient container by swiping down
5. keep the container opening and remove all recipients
6. the issue happens
[Blocking Requested - why for this release]:

Probably a regression or left over from bug 1015841.
Blocks: 1015841
blocking-b2g: --- → 2.1?
I'd like to look into this bug and I suppose that the container should return singleline style automatically whenever there's only one recipient in it.
Assignee: nobody → lchang
Status: NEW → ASSIGNED
(In reply to Julien Wajsberg [:julienw] from comment #1)
> [Blocking Requested - why for this release]:
> 
> Probably a regression or left over from bug 1015841.

I thought we already had this bug long time ago, but this recipient list adjustment make difference between single line and multi line mode, so you can 'see' the list still kept in multi line mode easily now.
(In reply to Steve Chung [:steveck] from comment #3)
> (In reply to Julien Wajsberg [:julienw] from comment #1)
> > [Blocking Requested - why for this release]:
> > 
> > Probably a regression or left over from bug 1015841.
> 
> I thought we already had this bug long time ago, but this recipient list
> adjustment make difference between single line and multi line mode, so you
> can 'see' the list still kept in multi line mode easily now.

You're right, we also have one more issue (bug 1045493) related to removing recipients in expanded mode.
See Also: → 1045493
Attached file Pull Request 22772
Hi Steve,

Could you please help this? Thanks.
Attachment #8471429 - Flags: review?(schung)
Comment on attachment 8471429 [details] [review]
Pull Request 22772

Hi Luke, The patch looks good, but could you please add unit test to verify the view forced to singline when mode switch from multiline mode to singleline mode?
Attachment #8471429 - Flags: review?(schung)
Comment on attachment 8471429 [details] [review]
Pull Request 22772

Hi Steve,

I've added the unit test. Would you mind reviewing it again? Thanks.
Attachment #8471429 - Flags: review?(schung)
Comment on attachment 8471429 [details] [review]
Pull Request 22772

Only one nit in test, so r=me. Please make sure gaia try pass before merging, thanks!
Attachment #8471429 - Flags: review?(schung) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/c7047476c5341366706569774298f9347c088e11

Steve, Thanks for reviewing!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
blocking-b2g: 2.1? → ---
This issue has been verified successfully on Flame2.1
Verify video:"verify_1050682.mp4".

Flame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.