Refactoring TelephonyService.dial

RESOLVED FIXED in 2.1 S2 (15aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aknow, Assigned: aknow)

Tracking

unspecified
2.1 S2 (15aug)
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 11 obsolete attachments)

15.46 KB, patch
aknow
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8469892 [details] [diff] [review]
Part 1: Rename aIsEmergency to aIsDialEmergency
Attachment #8469892 - Flags: review?(htsai)
(Assignee)

Comment 2

4 years ago
Created attachment 8469893 [details] [diff] [review]
Part 2: Correct if condition
Attachment #8469893 - Flags: review?(htsai)
(Assignee)

Comment 3

4 years ago
Created attachment 8469894 [details] [diff] [review]
Part 3: Don't pass isDialEmergency to ril_worker
Attachment #8469894 - Flags: review?(htsai)
(Assignee)

Comment 4

4 years ago
Created attachment 8469895 [details] [diff] [review]
Part 4: Provide utility to pick argument
Attachment #8469895 - Flags: review?(htsai)
(Assignee)

Comment 5

4 years ago
Created attachment 8469896 [details] [diff] [review]
Part 5: Handle isEmergency correctly
Attachment #8469896 - Flags: review?(htsai)
(Assignee)

Comment 6

4 years ago
Created attachment 8469898 [details] [diff] [review]
Part 6: Other correction
Attachment #8469898 - Flags: review?(htsai)
(Assignee)

Comment 7

4 years ago
Created attachment 8469900 [details] [diff] [review]
Part 7: Rename aTelephonyCallback to aCallback
Attachment #8469900 - Flags: review?(htsai)
(Assignee)

Comment 8

4 years ago
Created attachment 8469901 [details] [diff] [review]
Part 8: Extract addCdmaChildCall
Attachment #8469901 - Flags: review?(htsai)
Attachment #8469892 - Flags: review?(htsai) → review+
(Assignee)

Comment 9

4 years ago
Created attachment 8469913 [details] [diff] [review]
Part 3#2: Don't pass isDialEmergency to ril_worker
Attachment #8469894 - Attachment is obsolete: true
Attachment #8469894 - Flags: review?(htsai)
Attachment #8469913 - Flags: review?(htsai)
Attachment #8469893 - Flags: review?(htsai) → review+
Comment on attachment 8469913 [details] [diff] [review]
Part 3#2: Don't pass isDialEmergency to ril_worker

Review of attachment 8469913 [details] [diff] [review]:
-----------------------------------------------------------------

Nice clean-up!
Attachment #8469913 - Flags: review?(htsai) → review+
Attachment #8469895 - Flags: review?(htsai) → review+
Attachment #8469896 - Flags: review?(htsai) → review+
Attachment #8469898 - Flags: review?(htsai) → review+
Attachment #8469900 - Flags: review?(htsai) → review+
Attachment #8469901 - Flags: review?(htsai) → review+
(Assignee)

Comment 11

4 years ago
Created attachment 8469976 [details] [diff] [review]
Part 9: Extract dialInternal
Attachment #8469976 - Flags: review?(htsai)
(Assignee)

Comment 12

4 years ago
Created attachment 8469977 [details] [diff] [review]
Part 10: Create constant for DIAL_ERROR_BAD_NUMBER
Attachment #8469977 - Flags: review?(htsai)
Attachment #8469976 - Flags: review?(htsai) → review+
Comment on attachment 8469977 [details] [diff] [review]
Part 10: Create constant for DIAL_ERROR_BAD_NUMBER

Review of attachment 8469977 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8469977 - Flags: review?(htsai) → review+
(Assignee)

Comment 14

4 years ago
Created attachment 8470734 [details] [diff] [review]
[final] Refactoring TelephonyService.dial. r=hsinyi

Squash all commits together.
Attachment #8469901 - Attachment is obsolete: true
Attachment #8469913 - Attachment is obsolete: true
Attachment #8469976 - Attachment is obsolete: true
Attachment #8469977 - Attachment is obsolete: true
Attachment #8469892 - Attachment is obsolete: true
Attachment #8469893 - Attachment is obsolete: true
Attachment #8469895 - Attachment is obsolete: true
Attachment #8469896 - Attachment is obsolete: true
Attachment #8469898 - Attachment is obsolete: true
Attachment #8469900 - Attachment is obsolete: true
Attachment #8470734 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/40dbead999f0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in before you can comment on or make changes to this bug.