Closed Bug 1050696 Opened 10 years ago Closed 10 years ago

Refactoring TelephonyService.dial

Tracking

(Not tracked)

Status:

RESOLVED FIXED

Milestone:

2.1 S2 (15aug)

People

(Reporter: aknow, Assigned: aknow)

Details

Attachments

(1 file, 11 obsolete files)

Part 1: Rename aIsEmergency to aIsDialEmergency 10 years ago Szu-Yu Chen [:aknow] (inactive) 2.91 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 2: Correct if condition 10 years ago Szu-Yu Chen [:aknow] (inactive) 3.21 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 3: Don't pass isDialEmergency to ril_worker 10 years ago Szu-Yu Chen [:aknow] (inactive) 2.86 KB, patch		Details \| Diff \| Splinter Review
Part 4: Provide utility to pick argument 10 years ago Szu-Yu Chen [:aknow] (inactive) 2.62 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 5: Handle isEmergency correctly 10 years ago Szu-Yu Chen [:aknow] (inactive) 4.03 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 6: Other correction 10 years ago Szu-Yu Chen [:aknow] (inactive) 4.68 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 7: Rename aTelephonyCallback to aCallback 10 years ago Szu-Yu Chen [:aknow] (inactive) 5.28 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 8: Extract addCdmaChildCall 10 years ago Szu-Yu Chen [:aknow] (inactive) 4.53 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 3#2: Don't pass isDialEmergency to ril_worker 10 years ago Szu-Yu Chen [:aknow] (inactive) 2.88 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 9: Extract dialInternal 10 years ago Szu-Yu Chen [:aknow] (inactive) 2.91 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
Part 10: Create constant for DIAL_ERROR_BAD_NUMBER 10 years ago Szu-Yu Chen [:aknow] (inactive) 2.49 KB, patch	hsinyi : review+	Details \| Diff \| Splinter Review
[final] Refactoring TelephonyService.dial. r=hsinyi 10 years ago Szu-Yu Chen [:aknow] (inactive) 15.46 KB, patch	aknow : review+	Details \| Diff \| Splinter Review

Szu-Yu Chen [:aknow] (inactive)

Assignee

Description

•

10 years ago

      No description provided.

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 1

•

10 years ago

Attached patch Part 1: Rename aIsEmergency to aIsDialEmergency (obsolete) — Details — Splinter Review

Attachment #8469892 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 2

•

10 years ago

Attached patch Part 2: Correct if condition (obsolete) — Details — Splinter Review

Attachment #8469893 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 3

•

10 years ago

Attached patch Part 3: Don't pass isDialEmergency to ril_worker (obsolete) — Details — Splinter Review

Attachment #8469894 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 4

•

10 years ago

Attached patch Part 4: Provide utility to pick argument (obsolete) — Details — Splinter Review

Attachment #8469895 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 5

•

10 years ago

Attached patch Part 5: Handle isEmergency correctly (obsolete) — Details — Splinter Review

Attachment #8469896 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 6

•

10 years ago

Attached patch Part 6: Other correction (obsolete) — Details — Splinter Review

Attachment #8469898 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 7

•

10 years ago

Attached patch Part 7: Rename aTelephonyCallback to aCallback (obsolete) — Details — Splinter Review

Attachment #8469900 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 8

•

10 years ago

Attached patch Part 8: Extract addCdmaChildCall (obsolete) — Details — Splinter Review

Attachment #8469901 - Flags: review?(htsai)

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469892 - Flags: review?(htsai) → review+

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 9

•

10 years ago

Attached patch Part 3#2: Don't pass isDialEmergency to ril_worker (obsolete) — Details — Splinter Review

Attachment #8469894 - Attachment is obsolete: true

Attachment #8469894 - Flags: review?(htsai)

Attachment #8469913 - Flags: review?(htsai)

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469893 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Comment 10

•

10 years ago

Comment on attachment 8469913 [details] [diff] [review]
Part 3#2: Don't pass isDialEmergency to ril_worker

Review of attachment 8469913 [details] [diff] [review]:
-----------------------------------------------------------------

Nice clean-up!

Attachment #8469913 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469895 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469896 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469898 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469900 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469901 - Flags: review?(htsai) → review+

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 11

•

10 years ago

Attached patch Part 9: Extract dialInternal (obsolete) — Details — Splinter Review

Attachment #8469976 - Flags: review?(htsai)

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 12

•

10 years ago

Attached patch Part 10: Create constant for DIAL_ERROR_BAD_NUMBER (obsolete) — Details — Splinter Review

Attachment #8469977 - Flags: review?(htsai)

Hsin-Yi Tsai (she/her) [:hsinyi]

Updated

•

10 years ago

Attachment #8469976 - Flags: review?(htsai) → review+

Hsin-Yi Tsai (she/her) [:hsinyi]

Comment 13

•

10 years ago

Comment on attachment 8469977 [details] [diff] [review]
Part 10: Create constant for DIAL_ERROR_BAD_NUMBER

Review of attachment 8469977 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Attachment #8469977 - Flags: review?(htsai) → review+

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 14

•

10 years ago

Attached patch [final] Refactoring TelephonyService.dial. r=hsinyi — Details — Splinter Review

Squash all commits together.

Attachment #8469892 - Attachment is obsolete: true

Attachment #8469893 - Attachment is obsolete: true

Attachment #8469895 - Attachment is obsolete: true

Attachment #8469896 - Attachment is obsolete: true

Attachment #8469898 - Attachment is obsolete: true

Attachment #8469900 - Attachment is obsolete: true

Attachment #8469901 - Attachment is obsolete: true

Attachment #8469913 - Attachment is obsolete: true

Attachment #8469976 - Attachment is obsolete: true

Attachment #8469977 - Attachment is obsolete: true

Attachment #8470734 - Flags: review+

Szu-Yu Chen [:aknow] (inactive)

Assignee

Comment 15

•

10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=aceb2844f90c

Keywords: checkin-needed

Ryan VanderMeulen [:RyanVM]

Comment 16

•

10 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/40dbead999f0

Keywords: checkin-needed

Ryan VanderMeulen [:RyanVM]

Comment 17

•

10 years ago

https://hg.mozilla.org/mozilla-central/rev/40dbead999f0

Status: NEW → RESOLVED

Closed: 10 years ago

Resolution: --- → FIXED

Target Milestone: --- → 2.1 S2 (15aug)

You need to log in before you can comment on or make changes to this bug.