Closed Bug 1050699 Opened 10 years ago Closed 10 years ago

[B2G] "Unknow SIM card state" is shown on "Call Settings" and "Messaging Settings" panels while the card state is ready

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 verified)

VERIFIED FIXED
2.1 S2 (15aug)
blocking-b2g 2.1+
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: hsinyi, Assigned: eragonj)

Details

Attachments

(2 files)

Seen this issue one buri, master build, pvt_build_id: 20140807160201

STR:
0) Precondition: With SIM pin enabled
1) Go to Settings App
2) Turn on airplane mode
3) You will see "SIM card not ready" on "Call Settings", "Messaging Settings" and "Cellular & Data" panels
4) Turn off airplane mode
5) Enter correct SIM pin

Actual result:
"Operator name" is displayed on "Cellular & Data" panel but "Unknown SIM card state" is displayed on "Call Settings" and "Messaging Settings" panels

Expected result:
"Operator name" is displayed on "Cellular & Data", "Call Settings" and "Messaging Settings" panels
[Blocking Requested - why for this release]:
Regression in a basic feature
blocking-b2g: --- → 2.1?
blocking-b2g: 2.1? → 2.1+
took it.
Assignee: nobody → ejchen
Hi Zibi,

This bug may be caused by l10n.js change in Settings app. (https://github.com/mozilla-b2g/gaia/commit/eced8a617b6fde7962e1746f4e65336aaddd86c3#diff-39)

I checked the code and it seems that if we `element.removeAttribute('data-l10n-id')` or ` element.setAttribute('data-l10n-id', '')` will not make the textContent empty.

I am thinking whether this should be fixed in l10n.js or Settings app. 

Any idea ?
Flags: needinfo?(gandalf)
It should be fixed in the settings app. mozL10n.setAttributes does less magic than mozL10n.localize on purpose. Since we cannot "undo" localization, we prefer not to do anything automatically.

In the future, when we'll move l10n to ShadowRoot, we will be able to clearly remove the l10n when attribute is removed. For now, we need to clear textContent of the node manually.
Flags: needinfo?(gandalf)
Attached file patch on master
Hi Arthur, can you help me review this patch ?! thanks :)
Attachment #8472160 - Flags: review?(arthur.chen)
Comment on attachment 8472160 [details] [review]
patch on master

r=me, thank you!
Attachment #8472160 - Flags: review?(arthur.chen) → review+
Thanks all, just merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/f2723dc82b677c4d9cbeb07e4f1120500c04750d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
Attached video video of issue verify
According to bug title, "Unknow SIM card state" is not shown any more, so it should be fixed. But according to Expected result, "Operator name" is not shown on "Cellular & Data", "Call Settings" and "Messaging Settings" panels on Settings page. If you tap these panels to enter these pages, the operator name will be shown.
Repro STR:
Precondition: With SIM PIN enabled
1) Go to Settings App
2) Turn on airplane mode
3) You will see "SIM card not ready" on "Call Settings", "Messaging Settings" and "Cellular & Data" panels
4) Turn off airplane mode
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        8ae086c39011bc8842b2a19bb5267906fa22345a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebbd5c65c3c1
Build-ID        20141124094013
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141124.130744
FW-Date         Mon Nov 24 13:07:55 EST 2014
Bootloader      L1TC00011880
Flags: needinfo?(fan.luo)
Status: RESOLVED → VERIFIED
Hi Reporter,
As comment 9 said, 
According to bug title, this bug should be fixed.
According to expected result, it is not fixed, but I think it does not affect.

Could you confirm? Thanks.
Flags: needinfo?(fan.luo) → needinfo?(htsai)
(In reply to Norry.L.F from comment #10)
> Hi Reporter,
> As comment 9 said, 
> According to bug title, this bug should be fixed.
> According to expected result, it is not fixed, but I think it does not
> affect.
> 
> Could you confirm? Thanks.

Confirmed this is fixed, thank you!
Flags: needinfo?(htsai)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: