Closed
Bug 1050709
Opened 11 years ago
Closed 11 years ago
execute preference.js in pre-app.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: rickychien)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
since preferences.js has been refactored on bug 1039219, now it has capacity to move into pre-app.js, but it would be better to keep |make preferences| for generating user.js, so in this issue, we will do:
1. remove all dependencies to preferences rule, then we won't execute preferences rule when execute |make|.
2. execute preferences.js in pre-app.js
that we can keep |make preferences| to generate user.js and also move it into pre-app.js.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → ricky060709
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Try server result
https://tbpl.mozilla.org/?rev=5615595ceb466043bd4f9eb8c7b3e43ee3387c01&tree=Gaia-Try
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8491276 -
Flags: review?(yurenju)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8491276 [details] [review]
Gaia PR
looks good!
Attachment #8491276 -
Flags: review?(yurenju) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks Yuren! PR Merged.
https://github.com/mozilla-b2g/gaia/commit/b8c3b18f99b06d8edd13a5fe659c98f197698903
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•