105072 - nsIClassicPluginFactory interface changed after my checkin

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Doug Turner (:dougt)]

nsIClassicPluginFactory is one of the interface that can't change iirc.  It was
modified last night after my checkin to fix a fizilla bustage.  This fix needs
to be backed out.

Comment 1

[Doug Turner (:dougt)]

The error on the fizzilla build was:

Error   : cannot convert
'nsIServiceManagerObsolete *' to
'nsIServiceManager *'
nsPluginHostImpl.cpp line 4228 &pluginTag->mEntryPoint);

I think that a static cast to the (nsIServiceManager)from the obsolete class is
what should work.  Patching coming up.

Comment 2

[Doug Turner (:dougt)]

Attachment: Proposed Diff v.1

Comment 3

[Doug Turner (:dougt)]

Patrick, can you review this change?

Comment 4

[Patrick C. Beard]

r=beard. You know we really could have gotten away with just changing from
nsIServiceManager to nsISupports, as that's the signature of NSGetFactory. A
plugin mustn't assume a static cast will work, but should use QueryInterface.
That's what the MRJ plugin does.

Comment 5

[Doug Turner (:dougt)]

checked in.  thanks

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You won't also need a cast in nsPluginClassicModule.cpp?

Comment 7

[Doug Turner (:dougt)]

hmm?  where?

Comment 8

[shrirang khanzode]

.