Closed
Bug 1050729
Opened 11 years ago
Closed 11 years ago
Reduce overpaint of the sms app
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Firefox OS Graveyard
Gaia::SMS
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
561 bytes,
patch
|
julienw
:
review+
|
Details | Diff | Splinter Review |
Julien, this should reduce the overpaint of the sms app by ~100. Result of less overpaint usually == more fps and a bit less ion memory consumed by the app.
Attachment #8469961 -
Flags: review?(felash)
Comment 1•11 years ago
|
||
Comment on attachment 8469961 [details] [diff] [review]
sms.patch
Review of attachment 8469961 [details] [diff] [review]:
-----------------------------------------------------------------
I don't know how to check the overpainting so I'll trust you on this. Useless code can be removed anyway :)
Just remove the whole block and then it's r=me !
::: apps/sms/style/sms.css
@@ +222,5 @@
> transform: translateX(-100%);
> }
>
> #main-wrapper[data-position='right'] .panel {
> + transform: none;
I think you can just remove the line and then this whole block
Attachment #8469961 -
Flags: review?(felash) → review+
Updated•11 years ago
|
Assignee: nobody → 21
Comment 2•11 years ago
|
||
master: 3fd2450f50d9b791823593300440831c8e989c91
(oops, I gave the wrong author to the patch, sorry)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•