Closed Bug 1050797 Opened 10 years ago Closed 10 years ago

Remove dead code in Fennec

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

There's some dead code in the Fennec codebase. We should kill it.
Attached patch PatchSplinter Review
Doesn't proguard find this stuff?
Attachment #8470058 - Flags: review?(rnewman)
Attachment #8470058 - Attachment is patch: true
Indeed it appears proguard finds many things.
One of the things it says is unused is GeckoApp.showPlugins(). And indeed that function appears to not be called from anywhere. GeckoApp.hidePlugins() is called though. This seems like a bug?
Flags: needinfo?(snorp)
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3) > One of the things it says is unused is GeckoApp.showPlugins(). And indeed > that function appears to not be called from anywhere. GeckoApp.hidePlugins() > is called though. This seems like a bug? Ugh, yeah. I think the result is that switching away from a tab with Flash and going back to it won't show the plugin anymore.
Flags: needinfo?(snorp)
Split off bug 1050925 for that.
The ProGuard listing suggests that this is post-inlining: 0:22.60 org.mozilla.gecko.GeckoAppShell: 0:22.60 private static final java.lang.String LOGTAG and it includes a lot of library stuff that ProGuard should indeed remove.
Comment on attachment 8470058 [details] [diff] [review] Patch If it builds, WFM!
Attachment #8470058 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: