10508 - nsTarget::HashCode() attempts invalid assignment

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect, P3)

Description

[tor]

nsTarget::HashCode(void) (in caps/src/nsTarget.cpp) attempts an
assignment of "itsPrincipal->HashCode(&code) = 0".  Since
nsIPrincipal::HashCode returns an unsigned long, this doesn't
make a lot of sense.  I'm not sure why other compilers are
letting this pass, but it does trip up the Sun native compilers.

BTW: caps/include/nsPrincipalTools.h needs a newline at the
end of the file.

Comment 1

[tor]

It looks like you might have wanted that line (928) to be parsed
"a?b:(c=0)" instead of the "(a?b:c)=0" indicated by the associativity
rules.  An extra set of parens helps it figure out the correct meaning:

===================================================================
RCS file: /cvsroot/mozilla/caps/src/nsTarget.cpp,v
retrieving revision 1.12
diff -u -r1.12 nsTarget.cpp
--- nsTarget.cpp        1999/07/24 03:58:19     1.12
+++ nsTarget.cpp        1999/07/26 17:47:33
@@ -925,7 +925,7 @@
 PRInt32
 nsTarget::HashCode(void)
 {      PRUint32 code;
-       (itsPrincipal != NULL) ? itsPrincipal->HashCode(& code) : code = 0;
+       (itsPrincipal != NULL) ? itsPrincipal->HashCode(& code) : (code = 0);
        return PL_HashString(itsName) + code;
 }

Comment 2

[Norris Boyd]

Could you take a look at this, ariel?

Comment 3

[tor]

Fix already in mozilla.org tree - resolving bug.

Comment 4

[dshea]

Reporter satisfied.
Fix checked in.
Setting verified to complete bug cycle.

Comment 5

[leger]

Moving all CAPS bugs to Security: CAPS component.  CAPS component will be 
deleted.