Notifications are missing icons

RESOLVED FIXED

Status

Mozilla Developer Network
Sign-in
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shobson, Assigned: davidwalsh)

Tracking

({access})

Details

(Whiteboard: backend)

(Reporter)

Description

3 years ago
All notifications should have icons for our colour blind users. There's code in the notifier to add it, it's either not being called or being suppressed for these notification.

Updated

3 years ago
Assignee: nobody → dwalsh
Severity: normal → minor
Keywords: access
Whiteboard: backend
(Assignee)

Comment 1

3 years ago
FWIW, all growl notifications are using icons, so it's the staticly loaded messages that require icons.

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/340f0b4029af0fef9335ca39e355a134b4638923
fix bug 1050991 - Add icons to all notifications

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
Commit pushed to github-connect-request at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/340f0b4029af0fef9335ca39e355a134b4638923
fix bug 1050991 - Add icons to all notifications

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/bf80855b187fea76ae857ec225d236c8a0c65572
bug 1050991 - Use more JS-like notification code

https://github.com/mozilla/kuma/commit/863cdac2f92677d5d1ad778c225698e25641a800
Merge pull request #3162 from darkwing/better-notification-method

bug 1050991 - Use more JS-like notification code
You need to log in before you can comment on or make changes to this bug.