Close button obscures header sign in widget on small screens

RESOLVED FIXED

Status

Mozilla Developer Network
Sign-in
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shobson, Unassigned)

Tracking

({mobile})

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8470261 [details]
Screen Shot 2014-08-08 at 13.53.48.png

In the header sign in widget drop down a close button appears over top the sign in options on smaller screens.
(Reporter)

Updated

3 years ago
Blocks: 1046775
Where should we put it?  Should be an easy update.

Updated

3 years ago
Severity: normal → major
Keywords: mobile

Updated

3 years ago
Severity: major → minor
(Reporter)

Comment 2

3 years ago
Created attachment 8471874 [details]
close-button-placement

I think, due to size constraints on mobile (which is what this button is intended for) we are going to have to keep it within the bounds of the widget. So I'm suggesting we fade out the "sign in" text whent he widget is open and place the close button in the top left in line with the other icons (see attachment)
Flags: needinfo?(dwalsh)
Severity: minor → blocker
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(dwalsh)
Resolution: --- → FIXED
Was merged 3 days ago:  https://github.com/mozilla/kuma/pull/2659
Reopening, tagged wrong bug number as its fixer.

Wow, that placement is interesting; I'll have a go at it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Solution provided here:

https://github.com/mozilla/kuma/pull/2697
Decreasing severity to shut off our bug pager.
Severity: blocker → major

Comment 7

3 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/05a016d43038c3c3e96d4a22f2260fd639e7c474
fix bug 1051016 - Move close button when login widget is hovered over

https://github.com/mozilla/kuma/commit/67f29ae3d8a78ba50b397c856a7049a745232dd3
Merge pull request #2697 from darkwing/1051016-close-button-again

fix bug 1051016 - Move close button when login widget is hovered over

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.