1051016 - Close button obscures header sign in widget on small screens

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Sign-in, defect)

Description

[Stephanie Hobson [:shobson]]

Attachment: Screen Shot 2014-08-08 at 13.53.48.png

In the header sign in widget drop down a close button appears over top the sign in options on smaller screens.

Comment 1

[David Walsh :davidwalsh]

Where should we put it?  Should be an easy update.

Comment 2

[Stephanie Hobson [:shobson]]

Attachment: close-button-placement

I think, due to size constraints on mobile (which is what this button is intended for) we are going to have to keep it within the bounds of the widget. So I'm suggesting we fade out the "sign in" text whent he widget is open and place the close button in the top left in line with the other icons (see attachment)

Comment 3

[David Walsh :davidwalsh]

Was merged 3 days ago:  https://github.com/mozilla/kuma/pull/2659

Comment 4

[David Walsh :davidwalsh]

Reopening, tagged wrong bug number as its fixer.

Wow, that placement is interesting; I'll have a go at it.

Comment 5

[David Walsh :davidwalsh]

Solution provided here:

https://github.com/mozilla/kuma/pull/2697

Comment 6

[Māris Fogels [:mars] (please needinfo)]

Decreasing severity to shut off our bug pager.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/05a016d43038c3c3e96d4a22f2260fd639e7c474
fix bug 1051016 - Move close button when login widget is hovered over

https://github.com/mozilla/kuma/commit/67f29ae3d8a78ba50b397c856a7049a745232dd3
Merge pull request #2697 from darkwing/1051016-close-button-again

fix bug 1051016 - Move close button when login widget is hovered over