Closed Bug 1051024 Opened 5 years ago Closed 5 years ago

Removing unstructured logs parsing in mochitest handlers

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: akachkach, Assigned: akachkach)

Details

Attachments

(1 file)

A temporary fix to bug 1043485 was to put back some unstructured logs parsing. Now that we landed structured logging for robocop (bug 1034267) I think it's safe to remove those.
(we still look for log messages starting with "TEST-UNEXPECTED" and dump them as errors when processing the logs, since some tests print those "manually")
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 8470275 [details] [diff] [review]
0001-Bug-1051024-Removing-unstructured-logs-parsing-in-mo.patch

Review of attachment 8470275 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though I'd like to see a try run with Robocop (preferably with and without a failure added).
Attachment #8470275 - Flags: review?(ahalberstadt) → review+
Robocop run with failures: https://tbpl.mozilla.org/?tree=Try&rev=ff0505cc3116
Looks good; Will do one without failures once the trees re-open.
Try run looks good.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1ec0cddf72d6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.