1051024 - Removing unstructured logs parsing in mochitest handlers

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Ahmed Kachkach [:akachkach]]

A temporary fix to bug 1043485 was to put back some unstructured logs parsing. Now that we landed structured logging for robocop (bug 1034267) I think it's safe to remove those.
(we still look for log messages starting with "TEST-UNEXPECTED" and dump them as errors when processing the logs, since some tests print those "manually")

Comment 1

[Ahmed Kachkach [:akachkach]]

Attachment: 0001-Bug-1051024-Removing-unstructured-logs-parsing-in-mo.patch

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8470275 [details] [diff] [review]
0001-Bug-1051024-Removing-unstructured-logs-parsing-in-mo.patch

Review of attachment 8470275 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though I'd like to see a try run with Robocop (preferably with and without a failure added).

Comment 3

[Ahmed Kachkach [:akachkach]]

Robocop run with failures: https://tbpl.mozilla.org/?tree=Try&rev=ff0505cc3116
Looks good; Will do one without failures once the trees re-open.

Comment 4

[Ahmed Kachkach [:akachkach]]

Try run without failures: https://tbpl.mozilla.org/?tree=Try&rev=dfb94fdc1efc

Comment 5

[Ahmed Kachkach [:akachkach]]

Woops, wrong link. Try run: https://tbpl.mozilla.org/?tree=Try&rev=c82d6210a493

Comment 6

[Ahmed Kachkach [:akachkach]]

Try run looks good.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ec0cddf72d6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ec0cddf72d6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9c6878ecff95