Closed
Bug 1051052
Opened 10 years ago
Closed 9 years ago
Generate candidates with SDP mid values
Categories
(Core :: WebRTC: Networking, defect, P2)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
backlog | webrtc/webaudio+ |
People
(Reporter: mt, Assigned: mjf)
Details
Attachments
(1 file)
We currently provide the sdpMid attribute set to the empty string for all of our candidates. This is off-spec.
Comment 1•9 years ago
|
||
Still relevant?
backlog: --- → webRTC+
Rank: 23
Flags: needinfo?(drno)
Priority: -- → P2
Comment 3•9 years ago
|
||
Here's where you'll need to start. JsepSessionImpl is going to need to choose the mid, and give it to us as an outparam. https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#2681
Assignee: nobody → mfroman
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate.
Attachment #8656049 -
Flags: review?(docfaraday)
Updated•9 years ago
|
Attachment #8656049 -
Flags: review?(docfaraday) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8656049 [details] MozReview Request: Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate. https://reviewboard.mozilla.org/r/18073/#review16187 ::: media/webrtc/signaling/test/jsep_session_unittest.cpp:616 (Diff revision 1) > if (!skipped) { Let's add a TODO(bug 1095793) here for adding the mid to mCandidatesToTrickle.
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8656049 [details] MozReview Request: Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate. Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate.
Attachment #8656049 -
Flags: review+ → review?(docfaraday)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8656049 [details] MozReview Request: Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate. Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate.
Comment 8•9 years ago
|
||
Comment on attachment 8656049 [details] MozReview Request: Bug 1051052 - Made mid an outparam in JsepSession::AddLocalIceCandidate. https://reviewboard.mozilla.org/r/18073/#review16295
Attachment #8656049 -
Flags: review?(docfaraday) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cf60ea20de72
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•