1051108 - [B2G][FxA][Account Confirmation] User is never informed their email is invalid

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: FxA, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-FXA.txt

Description:
If the player inputs an invalid email address, they are not given any kind of notification that the address is invalid, or that the confirmation email was not delivered.  The user may not realize that the address wasn't valid, and wait for the email to be received, or repeatedly try to resend the email without any feedback.  As long as there is a '@' symbol somewhere in the middle of the address, it is accepted.


Repro Steps:
1) Update a Flame to 20140808040304
2) Navigate to Firefox Accounts in Settings
3) Input an invalid email address (such as 'a@a')
4) Input a Year of Birth and Password, then send the Confirmation Email.


Actual:
User progresses through account creation, but never receives any indication that the email is not valid.


Expected:
User is notified the email is invalid.

Environmental Variables:
Device: Flame Master
Build ID: 20140808040304
Gaia: c45627132ae7f00026e361a14d5d084a1236af24
Gecko: 18f408a5984e
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Keywords: Email, FxA, Firefox Account, Validation, Invalid, Confirmation


Repro frequency: 100%
See attached: screenshot, logcat

Comment 1

[Martin Shuman [:Marty]]

Attachment: FxA_Screenshot.png

This issue DOES occur on Flame 2.0 at 319MB and 512MB, as well as Flame 2.1 at 319MB and 512MB.

Email address is not validated.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140808000201
Gaia: 8d4599d18fbfc41f88ea494ab9cce0bb99cffac3
Gecko: aad73d079368
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

I know some areas do an email validation check.

Marcia, does this belong with FXA or Email component?  And looking for your input on nomination.

Comment 3

[Marcia Knous [:marcia]]

Adding No-Jun to NI as he owns this area for FX Accounts.

Comment 4

[No-Jun Park [:njpark]]

Similiar bugs has been raised before, but at the time those were marked as WONTFIX because our engineering resources  were limited. (And email address of format abc@cdf is technically valid) See bug 1007866 and bug 1021434.  

Perhaps for 2.1 we can take this bug as enhancement request?  Adding Jared for NI here.

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We are just using the email validation that's built into Gecko[1], and which follows the RFC format for emails[2].

Closing as wontfix (only because I can't find the related bugs to dupe this one), thanks for raising it though :-)


[1] https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Semantic_input_types
[2] see, eg, the list of RFCs here: http://en.wikipedia.org/wiki/Email_address#Syntax

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Oh, I should add - the product decision was to follow these external definitions of email addresses for FxA. Definitely feel free to ping arog or vishy about narrowing the scope of permitted addresses for some future version.