We should not compute ubi::Edge names unless requested

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla34
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
As shown in bug 1012456 comment 39, computing edge names eagerly can be quite expensive, and not all applications of ubi::Node need edge names. ubi::Node::edges and ubi::BreadthFirst should let you specify whether or not you want edge names.
(Assignee)

Updated

4 years ago
Blocks: 1012456
(Assignee)

Comment 1

4 years ago
Created attachment 8470364 [details] [diff] [review]
Let users tell ubi::Edge not to provide edge names, as they're expensive to compute, and not everyone needs them.
(Assignee)

Comment 3

4 years ago
An earlier patch failed the SpiderMonkey style checker; trying again:
https://tbpl.mozilla.org/?tree=Try&rev=40b12fea0f98
(Assignee)

Updated

4 years ago
Attachment #8470364 - Flags: review?(terrence)
Attachment #8470364 - Flags: review?(terrence) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f0fc022a099
Flags: in-testsuite-
Target Milestone: --- → mozilla34
https://hg.mozilla.org/mozilla-central/rev/0f0fc022a099
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.