Closed
Bug 1051115
Opened 10 years ago
Closed 10 years ago
We should not compute ubi::Edge names unless requested
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jimb, Assigned: jimb)
References
Details
Attachments
(1 file)
As shown in bug 1012456 comment 39, computing edge names eagerly can be quite expensive, and not all applications of ubi::Node need edge names. ubi::Node::edges and ubi::BreadthFirst should let you specify whether or not you want edge names.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=9a23d897903c
Assignee | ||
Comment 3•10 years ago
|
||
An earlier patch failed the SpiderMonkey style checker; trying again: https://tbpl.mozilla.org/?tree=Try&rev=40b12fea0f98
Assignee | ||
Updated•10 years ago
|
Attachment #8470364 -
Flags: review?(terrence)
Updated•10 years ago
|
Attachment #8470364 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f0fc022a099
Flags: in-testsuite-
Target Milestone: --- → mozilla34
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0f0fc022a099
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•