1051116 - Default to a search query for search suggestions

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Brian Nicholson (:bnicholson)]

(From https://bugzilla.mozilla.org/show_bug.cgi?id=1050943#c4)
> Looking at [1], isSearchQuery does a URL load rather than a search if
> isSearchQuery() returns false. We pass false to use as the default if we
> can't determine whether the query is a URL or a search, which seems like a
> bug to me -- I always thought we defaulted to true (i.e., a search) there.

We should default to a search unless we know that the suggestion we're clicking is a URL. Fixing this isn't as important since bug 693808 landed, but we should still do the right thing. The current behavior would also be broken if bug 909536 were to land (since clicking suggestions from the non-default provider would always end up search through the default search engine via nsIURIFixup).

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Default to a search query for search suggestions

Comment 2

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/26c80d563714

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26c80d563714

Comment 4

[Sudhir]

Can I pick this bug for testing? If so, can i know the test-steps for the same?

Thanks,
Sudhir