[traceback] kitsune.wiki.tasks._add_short_links_chunked kicks up SlugCollision()

RESOLVED FIXED in 2014Q3

Status

support.mozilla.org
Code Quality
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: willkg, Assigned: deanj)

Tracking

unspecified
2014Q3

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=dev c=wiki p=1 s=2014.15)

I've seen a fair number of these now in both stage and production environments:


Task kitsune.wiki.tasks._add_short_links_chunked with id 8a620a1c-f383-4d77-b2ef-3413935fa049 raised exception:
'SlugCollision()'


Task was called with args: [[<Document: [en-US] test_article_1407553769364456>]] kwargs: {}.

The contents of the full traceback was:

Traceback (most recent call last):
  File "/data/www/support.allizom.org/kitsune/vendor/src/celery/celery/task/trace.py", line 233, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/data/www/support.allizom.org/kitsune/vendor/src/celery/celery/task/trace.py", line 420, in __protected_call__
    return self.run(*args, **kwargs)
  File "/data/www/support.allizom.org/kitsune/kitsune/wiki/tasks.py", line 168, in _add_short_links_chunked
    doc.save()
  File "/data/www/support.allizom.org/kitsune/kitsune/wiki/models.py", line 248, in save
    self._raise_if_collides('slug', SlugCollision)
  File "/data/www/support.allizom.org/kitsune/kitsune/wiki/models.py", line 152, in _raise_if_collides
    raise exception
SlugCollision


That looks really fishy. That task shouldn't be kicking up SlugCollisions.

In my mailbox, I see 54 of these from production starting on 7/13/2014. I see a bunch from stage, too, starting on 7/10/2014.

Having said that, I'm pretty sure my trash folder is set to expunge anything more than a month old, so it's possible there are a bunch that are older that I don't have anymore.
No idea what's going on. Going conservative with 2pts.
Priority: -- → P1
Whiteboard: u=dev c=wiki p=2 s=2014.15
Target Milestone: --- → 2014Q3
The changes in this pull request might fix the issue:
https://github.com/mozilla/kitsune/pull/2066

We'll find out.
Whiteboard: u=dev c=wiki p=2 s=2014.15 → u=dev c=wiki p=1 s=2014.15
(Assignee)

Updated

4 years ago
Assignee: nobody → djohnson
Now I am seeing:

Task kitsune.wiki.tasks._add_short_links_chunked with id b9f98880-1c17-4724-8818-a11ae1e298c5 raised exception:
'AttributeError("\'long\' object has no attribute \'locale\'",)'


Task was called with args: [[21765L]] kwargs: {}.

The contents of the full traceback was:

Traceback (most recent call last):
  File "/data/www/support.mozilla.com/kitsune/vendor/src/celery/celery/task/trace.py", line 233, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/data/www/support.mozilla.com/kitsune/vendor/src/celery/celery/task/trace.py", line 420, in __protected_call__
    return self.run(*args, **kwargs)
  File "/data/www/support.mozilla.org/kitsune/kitsune/wiki/tasks.py", line 165, in _add_short_links_chunked
    # The next run of the `generate_missing_share_links` cron job will
AttributeError: 'long' object has no attribute 'locale'
Do we know if celery has restarted? If it didn't restart, then it's probably looking at old code. I suspect that's the issue here because the traceback doesn't line up with any attribute access for locale.
(Assignee)

Comment 5

4 years ago
add_short_links_chunked doesn't exist on prod anymore.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 6

4 years ago
Seems to be fixed on prod via https://github.com/mozilla/kitsune/pull/2066. Closing.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.