10515 - [PP] incorrect logic in keybindings with Control/Command key

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Kathleen :Brade]

Add the following keybinding (if it isn't already present):
in mozilla/editor/ui/composer/content/EditorAppShell.xul, below </script> add:
 <keyset>
   <key id="wcmdkey" disabled="false" shift="false" command="true" alt="false"
key="w" onkeypress="EditorClose()"/>
 </keyset>


Comments from joki:
To get this to work on a PC you currently have to set both in the key handler.
Saari has the code ifdeffed to return true for isCommand on a PC if the control
key is down but it also, of course, returns true to isControl.  Since the handler
is only defined for command, not command and control, the match fails.

Expectation: I expect to only define the keybinding once in xul as above.

Comment 1

[Akkana Peck]

Joining cc list because I'm eagerly awaiting having keybindings work on linux.

Comment 2

[saari (gone)]

The logic has been changed to this:



	            PRBool isCommand = PR_FALSE;

		            PRBool isControl = PR_FALSE;

		            theEvent->GetMetaKey(&isCommand);

		            theEvent->GetCtrlKey(&isControl);

		            if (((isCommand && (modCommand != "true")) ||

		                (!isCommand && (modCommand == "true"))) &&

		                ((isControl && (modControl != "true")) ||

		                (!isControl && (modControl == "true"))))

		              break;

Comment 3

[phillip]

code level fix, marking verified. reopen if i'm wrong here...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c06bba54166
[components] For https://github.com/mozilla-mobile/android-components/issues/10515 - Populate the CrashReporterActivity layout.