IonMonkey: Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits

RESOLVED FIXED in mozilla34

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dougc, Assigned: dougc)

Tracking

unspecified
mozilla34
Other
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Bug 1019831 broke the MIPS backend.
(Assignee)

Comment 1

4 years ago
Created attachment 8470524 [details] [diff] [review]
Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits.

This worked around build problems with the MIPS backend.
Attachment #8470524 - Flags: review?(benj)
(Assignee)

Updated

4 years ago
Blocks: 1019831
Comment on attachment 8470524 [details] [diff] [review]
Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits.

Review of attachment 8470524 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

::: js/src/jit/mips/Assembler-mips.h
@@ +165,5 @@
>  // this architecture or not. Rather than a method in the LIRGenerator, it is
>  // here such that it is accessible from the entire codebase. Once full support
>  // for SIMD is reached on all tier-1 platforms, this constant can be deleted.
>  static const bool SupportsSimd = false;
> +static const uint32_t SimdStackAlignment = 8;

So MIPS SIMD alignment is like ARM's? Interesting.
Attachment #8470524 - Flags: review?(benj) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8471262 [details] [diff] [review]
Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits.

Address reviewer feedback. Carrying forward r+.
Attachment #8471262 - Flags: review+
(Assignee)

Updated

4 years ago
Attachment #8470524 - Attachment is obsolete: true
(Assignee)

Comment 4

4 years ago
The MIPS backend is not tested by tbpl so asking to landed this without a try build.
Keywords: checkin-needed
QA Contact: dtc-moz
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8451b7fa46c
Assignee: nobody → dtc-moz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b8451b7fa46c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.