1051591 - IonMonkey: Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Douglas Crosher [:dougc]]

Bug 1019831 broke the MIPS backend.

Comment 1

[Douglas Crosher [:dougc]]

Attachment: Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits.

This worked around build problems with the MIPS backend.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8470524 [details] [diff] [review]
Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits.

Review of attachment 8470524 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

::: js/src/jit/mips/Assembler-mips.h
@@ +165,5 @@
>  // this architecture or not. Rather than a method in the LIRGenerator, it is
>  // here such that it is accessible from the entire codebase. Once full support
>  // for SIMD is reached on all tier-1 platforms, this constant can be deleted.
>  static const bool SupportsSimd = false;
> +static const uint32_t SimdStackAlignment = 8;

So MIPS SIMD alignment is like ARM's? Interesting.

Comment 3

[Douglas Crosher [:dougc]]

Attachment: Fix MIPS backend after SIMD x86/x64: Regalloc and moves bits.

Address reviewer feedback. Carrying forward r+.

Comment 4

[Douglas Crosher [:dougc]]

The MIPS backend is not tested by tbpl so asking to landed this without a try build.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8451b7fa46c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8451b7fa46c