1051599 - Keyboard does not handle mouse event well if cursor moved out/in of frame when pressed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Only happens when the keyboard app is loaded on a web page.

STR:

1. Press a key on the keyboard
2. Move the cursor out of the keyboard window

Expected:

1. Key handling got cancelled when the cursor moved out.

Actual:

1. The last key moved over remain clicked.


STR2:

1. Press and hold the mouse cursor
2. move the cursor into the keyboard frame, and release

Expected:

1. Keyboard ignores all events

Actual:

1. JS error when the mouse button is released.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/22755

This is trivial but since this is not related to actual development on the phone, I figured I should write the patch myself.

Getting close!

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8471275 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/22755

r=me with some comments about the variable naming.
Thank you.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/9483fb304235e7cedd4a7e8519ed091070ba9b22