1051609 - List of HTML5 tags broken

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[udeepak010]

Attachment: screen 1.JPG

Steps to reproduce:

1. Open Thimble.
2. Enter any invalid HTML5 tag.
3. Click on "List of HTML5 tags" link.


Actual results:

The link is no longer available.


Expected results:

List of HTML5 tags.

Comment 1

[Akshay S Dinesh]

I can confirm this.

And, it looks like Josh Duck has removed it from his site intentionally, because http://joshduck.com/projects.html links to the same page.

Here's an (unreliable?) mirror of the same: http://smm.zoomquiet.io/data/20110511083224/index.html

Maybe we should link to https://developer.mozilla.org/docs/Web/Guide/HTML/HTML5/HTML5_element_list

Comment 2

[Akshay S Dinesh]

https://github.com/mozilla/thimble.webmaker.org/blob/master/locale/en_US/thimble-dialog-messages.json#L12
seems to be the line that needs change. 

Also, a github search https://github.com/search?l=&q=joshduck+user%3Amozilla&ref=advsearch&type=Code&utf8=%E2%9C%93 brings up some other uses of the same link, which may also need to be fixed.

Comment 3

[udeepak010]

I have created a pull request in github: https://github.com/mozilla/thimble.webmaker.org/pull/440 .
The link has been replaced with another one.

Comment 4

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/440

Comment 5

[Jon Buckley [:jbuck]]

Hi udeepak010, thanks for writing a patch to fix this bug! Before we resolve this bug, we'll need to review and commit your patch.

Comment 6

[udeepak010]

OK Thanks.

Comment 7

[Akshay S Dinesh]

I'm thinking a web page (even if different from the "periodic table" style) would be better than an *image* of the periodic table.

Comment 8

[udeepak010]

I don't think that the page you have attached contains a list of all the HTML5 tags. And on top of that this was the image that was present in the existing link.

Comment 9

[Pomax]

Comment on attachment 8470821 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/440

let's use https://developer.mozilla.org/en/docs/Web/Guide/HTML/HTML5/HTML5_element_list instead here

Comment 10

[udeepak010]

So shall I make another pull request with the link you provided?

Comment 11

[Pomax]

no need for a new pull request, just update the branch you filed your PR for, and the pull request will automatically update along with it.

Comment 12

[udeepak010]

I've done that.

Comment 13

[Srikar Ananthula [:srikar]]

So is this bug solved or still some work pending ?

Comment 14

[udeepak010]

I am marking it as resolved as I have made the pull request and the bug has been solved.

Comment 15

[Jon Buckley [:jbuck]]

I just merged that pull request, so you'll see it on Thimble later today