Remove error numbers from js.msg

RESOLVED FIXED in mozilla34

Status

()

Product:
Core
Component:
JavaScript Engine
Status:
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

Version:
unspecified
Target:
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
93.62 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago
Posted patch remove-error-number (obsolete) — — Splinter Review 
This seems to work. I am using __COUNTER__ in embedjs.py, which should work with gcc and msvc.
(Assignee)

Comment 1

•
5 years ago
Posted patch v2 — — Splinter Review 
Now parses js.msg in embedjs.py instead of using __COUNTER__.
Assignee: nobody → evilpies
Attachment #8470545 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8470900 - Flags: review?(jorendorff)

Comment 2

•
5 years ago 
Comment on attachment 8470900 [details] [diff] [review]
v2

Review of attachment 8470900 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Thanks!

This creates a nice opportunity to group the error messages in js.msg so you can see some of the internal structure: frontend errors over here, proxy errors over there...

::: js/src/jsapi.cpp
@@ +550,1 @@
>      JS_END_MACRO;

Pfft. While you're here, please remove the JS_BEGIN_MACRO and JS_END_MACRO; lines. That's not what those macros are for, lol.
Attachment #8470900 - Flags: review?(jorendorff) → review+

Comment 4

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/67e348e5f8dd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.