Closed
Bug 1051611
Opened 11 years ago
Closed 11 years ago
Remove error numbers from js.msg
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: evilpies, Assigned: evilpies)
Details
Attachments
(1 file, 1 obsolete file)
|
93.62 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
This seems to work. I am using __COUNTER__ in embedjs.py, which should work with gcc and msvc.
|
Assignee | |
Comment 1•11 years ago
|
||
Now parses js.msg in embedjs.py instead of using __COUNTER__.
Assignee: nobody → evilpies
Attachment #8470545 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8470900 -
Flags: review?(jorendorff)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8470900 [details] [diff] [review]
v2
Review of attachment 8470900 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great. Thanks!
This creates a nice opportunity to group the error messages in js.msg so you can see some of the internal structure: frontend errors over here, proxy errors over there...
::: js/src/jsapi.cpp
@@ +550,1 @@
> JS_END_MACRO;
Pfft. While you're here, please remove the JS_BEGIN_MACRO and JS_END_MACRO; lines. That's not what those macros are for, lol.
Attachment #8470900 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•