1051698 - Reduce use of proxy methods and generated getters in 'widget' code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Kitching [:ckitching]]

Part of a series of mostly-generated patches providing cleanup and code audit for a common antipattern (see Bug 1039898).

This series is divided based on package boundaries. This bug tracks work in the "widget" package.

Comment 1

[Chris Kitching [:ckitching]]

Attachment: Reduce use of proxy methods and generated getters in 'widget' code.

Patch, r+'d over in Bug 1039898, Comment 97.

Comment 2

[Chris Kitching [:ckitching]]

https://hg.mozilla.org/integration/fx-team/rev/94d590dac62e

Comment 3

[Chris Kitching [:ckitching]]

Attachment: Reduce use of proxy methods and generated getters in TwoWayView.

The TwoWayView changes, for lucasr's perusal.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8470712 [details] [diff] [review]
Reduce use of proxy methods and generated getters in TwoWayView.

Review of attachment 8470712 [details] [diff] [review]:
-----------------------------------------------------------------

Before we go ahead with this, a question: is it worth it? Keep in mind that the recommendation to avoid the wrappers only actually applies to performance hotspots in the app. I find these changes a bit distracting and very unlikely to be applied consistently throughout our code base.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94d590dac62e