B2G NFC: Add marionette test for peer.sendFile

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
NFC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: allstars, Assigned: allstars)

Tracking

unspecified
2.1 S8 (7Nov)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Currently we don't have tests for peer.sendFile, we should write one.
(Assignee)

Comment 1

3 years ago
Created attachment 8470756 [details] [diff] [review]
Patch
(Assignee)

Updated

3 years ago
Attachment #8470756 - Flags: review?(dlee)
(Assignee)

Updated

3 years ago
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
Comment on attachment 8470756 [details] [diff] [review]
Patch

Review of attachment 8470756 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/tests/marionette/test_nfc_peer_sendFile.js
@@ +16,5 @@
> +  NCI.deactivate().then(() => toggleNFC(false)).then(runNextTest);
> +}
> +
> +function testSendFile() {
> +  nfc.onpeerready = function (evt) {

Nits. space after function, here and below
Attachment #8470756 - Flags: review?(dlee) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8471366 [details] [diff] [review]
Patch. v2

addressed nits.
Attachment #8470756 - Attachment is obsolete: true
Attachment #8471366 - Flags: review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/52fc270e59ad

Comment 5

3 years ago
https://hg.mozilla.org/mozilla-central/rev/52fc270e59ad
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 6

3 years ago
Reverted for intermittent test failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45922784&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/dd1174deb44c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/dd1174deb44c
(Assignee)

Comment 8

3 years ago
run try again, and the tree is green.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6656acda1059
(Assignee)

Comment 9

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/dbbb19ff9525
Target Milestone: 2.1 S2 (15aug) → 2.1 S8 (7Nov)
https://hg.mozilla.org/mozilla-central/rev/dbbb19ff9525
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.