Closed Bug 1051754 Opened 5 years ago Closed 5 years ago

B2G NFC: Add marionette test for peer.sendFile

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S8 (7Nov)

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file, 1 obsolete file)

Currently we don't have tests for peer.sendFile, we should write one.
Attached patch Patch (obsolete) — Splinter Review
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
Comment on attachment 8470756 [details] [diff] [review]
Patch

Review of attachment 8470756 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/tests/marionette/test_nfc_peer_sendFile.js
@@ +16,5 @@
> +  NCI.deactivate().then(() => toggleNFC(false)).then(runNextTest);
> +}
> +
> +function testSendFile() {
> +  nfc.onpeerready = function (evt) {

Nits. space after function, here and below
Attachment #8470756 - Flags: review?(dlee) → review+
Attached patch Patch. v2Splinter Review
addressed nits.
Attachment #8470756 - Attachment is obsolete: true
Attachment #8471366 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/52fc270e59ad
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Reverted for intermittent test failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45922784&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/dd1174deb44c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/dbbb19ff9525
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.