1051758 - Lockscreen Visual Refresh: "More Notifications" hairline is misaligned

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2014-08-11-18-28-24.png

When lockscreen has more than 4 notifications (on Flame, without music player widget), the "More notifications" hairline is displaced from the fourth notification's bottom hairline. See attachment. This goes contrary to the implementation of bug 1023500, where the two hairlines should overlap together and visually looks like only one hairline.

This is probably a regression. But I think I will fix it without taking too much time finding the patch that caused this.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Note: Quick look and this was caused by 1045656 with CSS changes.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Hi Amy,

Could you check if the hairlines align/overlap properly with this patch? Thanks a lot!

Comment 3

[Amy Lee [:amylee] UX]

Comment on attachment 8471328 [details] [review]
Patch (PR @ GitHub)

Hi, 

Thanks for fixing the hairline alignment!

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8471328 [details] [review]
Patch (PR @ GitHub)

Hi Greg, here's a trivial CSS patch for you to review. Thanks!

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/596d0e063e55409c3ad6aba5803f01b6d55f3d7b