1051892 - Fix comments in PSL

Status: RESOLVED FIXED

(Core Graveyard :: Networking: Domain Lists, defect)

Description

[Gervase Markham [:gerv]]

Steve Sheng writes:


Hi Jothan and Gerv,

  I have downloaded the latest version of the PSL  to do some analysis for
the SSAC, and I come across some inconsistencies:

1. In the PSL 

// xn--30rr7y : 2014-06-13 Excellent First Limited
xn—30rr7y

>> Shouldn’t the U-label be displayed here?

FYI, from our python code:

// xn--30rr7y : 2014-06-12 Excellent First Limited
慈善


2. In the PSL 

// xn--9et52u : 2014-06-13 RISE VICTORY LIMITED
xn--9et52u


>> Shouldn’t the U-label be displayed here?

FYI, from our python code:


From ICANN’s python code
// xn--9et52u : 2014-06-12 RISE VICTORY LIMITED
时尚



3. 

In the PSL 

// xn--vermgensberater-ctb : 2014-06-23 Deutsche Vermögensberatung
Aktiengesellschaft DVAG
xn--vermgensberater-ctb

// xn--vermgensberatung-pwb : 2014-06-23 Deutsche Vermögensberatung
Aktiengesellschaft DVAG
xn--vermgensberatung-pwb



>> Shouldn’t the U-label be displayed here?

FYI, from our python code, which gave the wrong output.



// xn--vermgensberater-ctb : 2014-06-23 Deutsche Verm<F6>gensberatung
Aktiengesellschaft DVAG
verm<F6>gensberater

// xn--vermgensberatung-pwb : 2014-06-23 Deutsche Verm<F6>gensberatung
Aktiengesellschaft DVAG
verm<F6>gensberatung

NOTE: here our python code is unable to handle this. It should really be:

xn--vermgensberater-ctb, vermögensberater (U-label)

xn--vermgensberatung-pwb,vermögensberatung (U-label)

Thanks,
 
Kind regards, 

Steve

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 2

[Gervase Markham [:gerv]]

Tests passed.

Gerv

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f4a56fb02d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2f4a56fb02d