Integrate the webmaker-auth module into the webmaker-landing-pages server for local dev

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jbuck, Assigned: akirose)

Tracking

Details

(Whiteboard: [webmakersnippet])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
As per bug 1047521, we need to have a way to test webmaker login on the landing pages locally. Hopefully this is just integrating webmaker-auth into the grunt task, but perhaps there is more work to do here.
(Assignee)

Updated

4 years ago
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [webmakersnippet]
(Assignee)

Updated

4 years ago
Depends on: 1052018
(Assignee)

Updated

4 years ago
Depends on: 1052019
(Reporter)

Comment 2

4 years ago
Comment on attachment 8471388 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/50

I don't think this is the right approach. I think your plan of "I might ultimately use grunt-shell to run an express server to match what we have on staging and prod" is the right way forward here
Attachment #8471388 - Flags: review?(jon) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8472847 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/53

I think I have something a little better here. The server is running locally, and everything is working great. I think.
Attachment #8471388 - Attachment is obsolete: true
Attachment #8472847 - Flags: review?(jon)
(Reporter)

Comment 4

4 years ago
Comment on attachment 8472847 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/53

I put a bunch of nits in the PR, but it works great. r+!
Attachment #8472847 - Flags: review?(jon) → review+

Comment 5

4 years ago
Commits pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/0f36929d3eae202246f6dbb258a40ada3106d221
Bug 1052017 - Integrate the webmaker-auth module into the webmaker-landing-pages server for local dev

https://github.com/mozilla/webmaker-landing-pages/commit/e37d9184843e3302e2103b4fa478461d8707d158
Merge pull request #53 from gesa/1052017/create-account

Fixes Bug 1052017 - Integrate the webmaker-auth module into the webmaker-landing-pages server for local dev

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.