Closed
Bug 1052042
Opened 10 years ago
Closed 10 years ago
Move the cx stack-pop GC from AutoCxPusher to AutoEntryScript
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(2 files)
|
1.28 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
|
3.42 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
This needs to happen, and I want to split it out into its own bug because of the potential to alter GC patterns and perturb performance tests like SunSpider.
|
Assignee | |
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8085c27f6acb
|
|
Assignee | |
Comment 2•10 years ago
|
||
We're about to give AutoEntryScript (a subclass) a non-virtual destructor, which is safe so long as these things are only stack-allocated.
Attachment #8471693 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8471695 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=e7dd4933d0c0
Attachment #8471693 -
Flags: review?(wmccloskey) → review+
Attachment #8471695 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=865ea7b23ce6
|
|
Assignee | |
Comment 6•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d60846941972 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/05842b43f23b
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d60846941972 https://hg.mozilla.org/mozilla-central/rev/05842b43f23b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•