Move the cx stack-pop GC from AutoCxPusher to AutoEntryScript

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla34
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

5 years ago
This needs to happen, and I want to split it out into its own bug because of the potential to alter GC patterns and perturb performance tests like SunSpider.
Assignee

Comment 2

5 years ago
We're about to give AutoEntryScript (a subclass) a non-virtual destructor, which
is safe so long as these things are only stack-allocated.
Attachment #8471693 - Flags: review?(wmccloskey)
Attachment #8471693 - Flags: review?(wmccloskey) → review+
Attachment #8471695 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/d60846941972
https://hg.mozilla.org/mozilla-central/rev/05842b43f23b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.