Closed
Bug 1052062
Opened 10 years ago
Closed 10 years ago
Error console doesn't show all error messages shown by remote debugging
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird36 fixed)
RESOLVED
FIXED
Thunderbird 36.0
Tracking | Status | |
---|---|---|
thunderbird36 | --- | fixed |
People
(Reporter: aryx, Assigned: aryx)
Details
Attachments
(1 file, 1 obsolete file)
1.37 KB,
patch
|
Details | Diff | Splinter Review |
Thunderbird 34.0a1 20140723 on Windows 8.1 When using remote debugging to connect to a new Daily profile using Firefox Nightly, I can see some error messages which Tools > Error Console doesn't show. Only visible in remote debugging: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgFolder.getStringProperty]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://messenger/content/folderPane.js :: getSmartFolderName :: line 2675" data: no] folderPane.js:2677 Visible in error console and remote debugging: listManager.setUpdateUrl is not a function nsPhishingProtectionApplication.js:156 CCing Ratty as error console pro.
I think I have seen this message even without remote debugging (I do not use it ever). I think it was in some of the folder modes other than All. Do you have these prefs enabled? user_pref("javascript.options.showInConsole", true); user_pref("javascript.options.strict", true); user_pref("javascript.options.strict.debug", true);
Assignee | ||
Comment 2•10 years ago
|
||
With these preferences set, I see these errors. Should we set these preferences by default?
If we could distinguish debug builds from release builds I would be for making them default. Then you'll see a few warnings just by starting TB.
Assignee | ||
Comment 4•10 years ago
|
||
Like http://mxr.mozilla.org/comm-central/source/mail/app/profile/all-thunderbird.js#25 ?
Yeah, probably. But as the pref is defined in http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpref/init/all.js#964 it just needs a test, whether the override in thunderbird.js (or mailnews.js) will work.
Assignee | ||
Comment 6•10 years ago
|
||
The override in thunderbird.js works. Adding the three prefs from comment 0 shows 80 messages in the error console after startup (2 errors). Wouldn't be switching javascript.options.showInConsole to true be sufficient for showing the errors (it does when I test and that's how I remember the pref).
Yes. The *strict* options probably enable JS strict mode, which seems to warn about potential problems (e.g. calls to undefined methods), which may or may not be a problem. There probably are reasons why it is not yet enabled by default. I use to find pontential bugs, but yes, it is up to the other guys if they also want this to be in the default prefs for debug build. Will you make the patch?
Comment 8•10 years ago
|
||
1. Don't default javascript.options.strict to true as this tends to spam the Error Console with too much noise. (javascript.options.strict should really be called j.o.pedantic). 2. I agree that javascript.options.showInConsole should default to true. 3. Also the toolkit Error Console is now NPOTB from the perspective of Firefox. It should be relatively easy to make a change in all.js instead of overriding it in Thunderbird/SeaMonkey/etc. You can't even open the toolkit Error Console in Firefox (unless you use an extension, e.g. Console2).
Assignee | ||
Comment 9•10 years ago
|
||
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #8477875 -
Flags: review?(standard8)
Comment 10•10 years ago
|
||
Comment on attachment 8477875 [details] [diff] [review] patch, v1 Yeah, this looks fine to do.
Attachment #8477875 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8477875 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 12•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/aa0afef70cd6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Updated•9 years ago
|
status-thunderbird36:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•