Closed
Bug 1052074
Opened 10 years ago
Closed 10 years ago
Improve error messages for protocol.js exceptions
Categories
(DevTools :: Framework, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: dcamp, Assigned: dcamp)
Details
Attachments
(1 file)
|
4.24 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
Right now exceptions in protocol.js methods reach the transport layer. That's fine, it prints them out, but the attached patch handles them in the protocol.js layer so we can let the developer know which handler failed.
Attachment #8471022 -
Flags: review?(jsantell)
|
||
Comment 1•10 years ago
|
||
Looks good AFAICT, pushed to try too: https://tbpl.mozilla.org/?tree=Try&rev=c94bcef5c2d1
|
|
||
Updated•10 years ago
|
Attachment #8471022 -
Flags: review?(jsantell) → review+
|
|
||
Comment 2•10 years ago
|
||
Just wonder if there's any perf hits for all the try/catching on every protocol.js packet, can keep an eye on this
|
Assignee | |
Comment 3•10 years ago
|
||
All green here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bdbc81440ae9
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1a8a722c3dfc
Assignee: nobody → dcamp
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
||
Updated•10 years ago
|
Flags: qe-verify-
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•