Add a test that makes sure crashed GMP plugins are reported to the crash service

NEW
Unassigned

Status

()

Core
WebRTC
P5
normal
Rank:
55
3 years ago
2 years ago

People

(Reporter: adw, Unassigned, NeedInfo)

Tracking

Trunk
Points:
---
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8471117 [details] [diff] [review]
leaky test patch

Bug 1009765 landed without a test that makes sure crashed GMP plugins are reported to the crash service.  This patch, copied over from the other bug, adds adds one and makes related necessary changes, but it leaks a CondVar, GeckoChildProcessHost, and Mutex.

Filing this in Core::WebRTC because that's where the test in this patch lives.
Flags: firefox-backlog+
jesup, do you have any ideas?
Flags: needinfo?(rjesup)
In bug 1035056 I encountered this leak when plugins crashed while shutting down. I fixed it by ensuring that GeckoMediaPluginService::ReAddOnGMPThread() does not re-add a GMP clone if we're already shutting down. This is a different case (the GMP is not crashing while shutting down here, right?), but the cause could be something similar.
backlog: --- → webRTC+
Rank: 55
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.